Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2178)

Unified Diff: chrome/browser/views/bookmark_bar_view.h

Issue 2822010: Fixes bug in bookmark bar view if profile changed. If the profile (Closed)
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/bookmark_bar_view.h
diff --git a/chrome/browser/views/bookmark_bar_view.h b/chrome/browser/views/bookmark_bar_view.h
index 1aa8d1b466d8f1ca521a18a522bedc2f035eb76a..bb532fb8fcf70c61238bc141c1d5f3bea16a650c 100644
--- a/chrome/browser/views/bookmark_bar_view.h
+++ b/chrome/browser/views/bookmark_bar_view.h
@@ -50,6 +50,14 @@ class BookmarkBarView : public DetachableToolbarView,
friend class ShowFolderMenuTask;
public:
+ // Constants used in Browser View, as well as here.
+ // How inset the bookmarks bar is when displayed on the new tab page.
+ static const int kNewtabHorizontalPadding;
+ static const int kNewtabVerticalPadding;
+
+ // Maximum size of buttons on the bookmark bar.
+ static const int kMaxButtonWidth;
+
// Interface implemented by controllers/views that need to be notified any
// time the model changes, typically to cancel an operation that is showing
// data from the model such as a menu. This isn't intended as a general
@@ -213,22 +221,19 @@ class BookmarkBarView : public DetachableToolbarView,
// BookmarkBarInstructionsView::Delegate.
virtual void ShowImportDialog();
- // Maximum size of buttons on the bookmark bar.
- static const int kMaxButtonWidth;
-
// If a button is currently throbbing, it is stopped. If immediate is true
// the throb stops immediately, otherwise it stops after a couple more
// throbs.
void StopThrobbing(bool immediate);
+ // Returns the number of buttons corresponding to starred urls/groups. This
+ // is equivalent to the number of children the bookmark bar node from the
+ // bookmark bar model has.
+ int GetBookmarkButtonCount();
+
// If true we're running tests. This short circuits a couple of animations.
static bool testing_;
- // Constants used in Browser View, as well as here.
- // How inset the bookmarks bar is when displayed on the new tab page.
- static const int kNewtabHorizontalPadding;
- static const int kNewtabVerticalPadding;
-
private:
class ButtonSeparatorView;
struct DropInfo;
@@ -272,11 +277,6 @@ class BookmarkBarView : public DetachableToolbarView,
// Creates the button used when not all bookmark buttons fit.
views::MenuButton* CreateOverflowButton();
- // Returns the number of buttons corresponding to starred urls/groups. This
- // is equivalent to the number of children the bookmark bar node from the
- // bookmark bar model has.
- int GetBookmarkButtonCount();
-
// Invoked when the bookmark bar model has finished loading. Creates a button
// for each of the children of the root node from the model.
virtual void Loaded(BookmarkModel* model);
« no previous file with comments | « no previous file | chrome/browser/views/bookmark_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698