Issue 28213: Rebaseline a few tests from the last merge. Mark new tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28213: Rebaseline a few tests from the last merge. Mark new tests (Closed)

Created:
11 years, 9 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Finnur, sky, ojan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Rebaseline LayoutTests/editing/selection/select-all-iframe.html which Ojan changed upstream. Defer new tests. Fix wdiff to have deletes be red and new lines be green (it was reversed).

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : remove baseline #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/select-all-iframe-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/test_lists/tests_fixable.txt	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	webkit/tools/layout_tests/test_types/test_type_base.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Finnur

11 years, 9 months ago (2009-02-26 21:21:31 UTC) #3

It would help make this process less frustrating if you check the spreadsheet to
avoid conflicts. Some of those tests are already claimed and a fix is in review:

http://codereview.chromium.org/28211

On 2009/02/26 21:15:17, ojan wrote:
> LGTM

Expand Messages | Collapse Messages