Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 28211: I eated 9 moar layout t3stz (Closed)

Created:
11 years, 10 months ago by Finnur
Modified:
9 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

9 more layout tests taken off the pile. The tests below have had their baseline changed upstream and we need to follow suit (see diffs in review folder): -LayoutTests/fast/events/offsetX-offsetY.html -LayoutTests/editing/selection/select-from-textfield-outwards.html -LayoutTests/editing/selection/select-missing-image.html NOTE: For the last test above, we now match the mac baseline so I just removed our text baseline. New tests that just needed to be baselined (only differ in font metrics): -LayoutTests/fast/lists/list-marker-with-line-height.html -LayoutTests/fast/overflow/overflow-float-stacking.html -LayoutTests/fast/overflow/overflow-stacking.html -LayoutTests/fast/replaced/embed-display-none.html -LayoutTests/fast/replaced/applet-display-none.html -LayoutTests/fast/replaced/object-display-none.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -27 lines) Patch
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/select-from-textfield-outwards-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
D webkit/data/layout_tests/platform/chromium-win/LayoutTests/editing/selection/select-missing-image-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
M webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/events/offsetX-offsetY-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/lists/list-marker-with-line-height-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/lists/list-marker-with-line-height-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/lists/list-marker-with-line-height-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-float-stacking-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-float-stacking-expected.png View Binary file 0 comments Download
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-float-stacking-expected.txt View 1 chunk +157 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-stacking-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-stacking-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/overflow/overflow-stacking-expected.txt View 1 chunk +156 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-display-none-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-display-none-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/applet-display-none-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/embed-display-none-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/embed-display-none-expected.png View Binary file 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/embed-display-none-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/object-display-none-expected.checksum View 1 chunk +1 line, -0 lines 0 comments Download
A webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/object-display-none-expected.png View Binary file 0 comments Download
webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/replaced/object-display-none-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_lists/tests_fixable.txt View 3 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Finnur
I picked you to review this because you were the last person to rebaseline the ...
11 years, 10 months ago (2009-02-26 21:08:34 UTC) #1
brettw
11 years, 10 months ago (2009-02-26 21:39:14 UTC) #2
You are a layout test rebaselining machine! LGTM.

Powered by Google App Engine
This is Rietveld 408576698