Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: chrome/browser/automation/automation_provider.h

Issue 2821018: Follow-up on http://codereview.chromium.org/2861019 to address Powel's commen... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/automation_provider.h
===================================================================
--- chrome/browser/automation/automation_provider.h (revision 50678)
+++ chrome/browser/automation/automation_provider.h (working copy)
@@ -327,10 +327,6 @@
int64 id,
bool* success);
- // Util for creating a JSON error return string (dict with key
- // 'error' and error string value). No need to quote input.
- std::string JSONErrorString(std::string err);
-
// Set window dimensions.
// Uses the JSON interface for input/output.
void SetWindowDimensions(Browser* browser,
@@ -442,6 +438,10 @@
DictionaryValue* args,
IPC::Message* reply_message);
+ // Util for creating a JSON error return string (dict with key
+ // 'error' and error string value). No need to quote input.
+ static std::string JSONErrorString(std::string err);
Paweł Hajdan Jr. 2010/06/29 17:43:19 nit: "std::string err" -> "const std::string& err"
+
// Generic pattern for pyautolib
// Uses the JSON interface for input/output.
void SendJSONRequest(int handle,
« no previous file with comments | « no previous file | chrome/browser/automation/automation_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698