Follow-up on http://codereview.chromium.org/2861019 to address Powel's commen...

chrome/browser/automation/automation_provider.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This implements a browser-side endpoint for UI automation activity.
 // The client-side endpoint is implemented by AutomationProxy.
 // The entire lifetime of this object should be contained within that of
 // the BrowserProcess, and in particular the NotificationService that's
 // hung off of it.
 
@@ skipping 309 matching lines @@
   void SetBookmarkTitle(int handle,
                         int64 id, std::wstring title,
                         bool* success);
   void SetBookmarkURL(int handle,
                       int64 id, const GURL& url,
                       bool* success);
   void RemoveBookmark(int handle,
                       int64 id,
                       bool* success);
 
-  // Util for creating a JSON error return string (dict with key
-  // 'error' and error string value).  No need to quote input.
-  std::string JSONErrorString(std::string err);
-
   // Set window dimensions.
   // Uses the JSON interface for input/output.
   void SetWindowDimensions(Browser* browser,
                            DictionaryValue* args,
                            IPC::Message* reply_message);
 
   // Get info about the chromium/chrome in use.
   // This includes things like version, executable name, executable path.
   // Uses the JSON interface for input/output.
   void GetBrowserInfo(Browser* browser,
@@ skipping 91 matching lines @@
   void OmniboxAcceptInput(Browser* browser,
                           DictionaryValue* args,
                           IPC::Message* reply_message);
 
   // Save the contents of a tab into a file.
   // Uses the JSON interface for input/output.
   void SaveTabContents(Browser* browser,
                        DictionaryValue* args,
                        IPC::Message* reply_message);
 
+  // Util for creating a JSON error return string (dict with key
+  // 'error' and error string value).  No need to quote input.
+  static std::string JSONErrorString(std::string err);

[Paweł Hajdan Jr., 2010/06/29 17:43:19]

nit: "std::string err" -> "const std::string& err"

+
   // Generic pattern for pyautolib
   // Uses the JSON interface for input/output.
   void SendJSONRequest(int handle,
                        std::string json_request,
                        IPC::Message* reply_message);
 
   // Method ptr for json handlers.
   // Uses the JSON interface for input/output.
   typedef void (AutomationProvider::*JsonHandler)(Browser* browser,
                                                   DictionaryValue*,
@@ skipping 405 matching lines @@
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details);
 
   void OnRemoveProvider();  // Called via PostTask
 
   NotificationRegistrar registrar_;
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_H_