Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 282008: Add a variation of a stack to the base unittest umr flaky list. (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain
Modified:
9 years, 7 months ago
Reviewers:
erikkay
CC:
chromium-reviews_googlegroups.com, Erik does not do reviews, brettw, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add a variation of a stack to the base unittest umr flaky list. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M base/data/purify/base_unittests.exe_UMR_flakey.txt View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nicolas Sylvain
11 years, 2 months ago (2009-10-15 20:31:46 UTC) #1
erikkay
11 years, 2 months ago (2009-10-15 20:37:56 UTC) #2
LGTM


On Thu, Oct 15, 2009 at 1:31 PM,  <nsylvain@chromium.org> wrote:
> Reviewers: erikkay_google.com,
>
> Description:
> Add a variation of a stack to the base unittest umr flaky list.
>
>
> Please review this at http://codereview.chromium.org/282008
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> =A0M =A0 =A0 base/data/purify/base_unittests.exe_UMR_flakey.txt
>
>
> Index: base/data/purify/base_unittests.exe_UMR_flakey.txt
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- base/data/purify/base_unittests.exe_UMR_flakey.txt =A0(revision 29170=
)
> +++ base/data/purify/base_unittests.exe_UMR_flakey.txt =A0(working copy)
> @@ -12,3 +12,21 @@
> =A0 =A0testing/gtest/src/gtest.cc =A0testing::Test::Run(void)
> =A0 =A0^^^
>
> +Uninitialized memory read in
> base::PrivateKeyInfoCodec::PrependIntegerImpl(BYTE
> *,int,list<BYTE,allocator<BYTE>::std>::std *,bool)
> +Error Location
> + =A0 base/crypto/rsa_private_key.cc
> =A0base::PrivateKeyInfoCodec::PrependIntegerImpl(BYTE *,int,list::std *,b=
ool)
> + =A0 base/crypto/rsa_private_key.cc
> =A0base::PrivateKeyInfoCodec::PrependInteger(vector::std const&,list::std=
 *)
> + =A0 base/crypto/rsa_private_key.cc
> =A0base::PrivateKeyInfoCodec::Export(vector::std *)
> + =A0 base/crypto/rsa_private_key_win.cc
> =A0base::RSAPrivateKey::ExportPrivateKey(vector::std *)
> + =A0 base/crypto/rsa_private_key_unittest.cc
> =A0RSAPrivateKeyUnitTest_InitRandomTest_Test::TestBody(void)
> + =A0 testing/gtest/src/gtest.cc =A0testing::Test::Run(void)
> + =A0 ^^^
> +Alloc Location
> + =A0 ...
> + =A0 base/crypto/rsa_private_key.cc
> =A0base::PrivateKeyInfoCodec::PrependIntegerImpl(BYTE *,int,list::std *,b=
ool)
> + =A0 base/crypto/rsa_private_key.cc
> =A0base::PrivateKeyInfoCodec::PrependInteger(vector::std const&,list::std=
 *)
> + =A0 base/crypto/rsa_private_key.cc
> =A0base::PrivateKeyInfoCodec::Export(vector::std *)
> + =A0 base/crypto/rsa_private_key_win.cc
> =A0base::RSAPrivateKey::ExportPrivateKey(vector::std *)
> + =A0 base/crypto/rsa_private_key_unittest.cc
> =A0RSAPrivateKeyUnitTest_InitRandomTest_Test::TestBody(void)
> + =A0 testing/gtest/src/gtest.cc =A0testing::Test::Run(void)
> + =A0 ^^^
>
>
>

Powered by Google App Engine
This is Rietveld 408576698