Issue 282004: Fix for crash when a bookmark URL is an empty string...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282004: Fix for crash when a bookmark URL is an empty string... (Closed)

Created:
11 years, 2 months ago by Bruno

Modified:
7 years, 5 months ago

Reviewers:
ChrisCampbell, tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, sky

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Fix for crash when a bookmark URL is an empty string BUG=19852 TEST=See repro steps of the bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30540

Total comments: 1

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/bookmarks/bookmark_codec.cc	View		1 chunk	+3 lines, -2 lines	1 comment	Download
	M	chrome/browser/bookmarks/bookmark_storage.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

tim (not reviewing)

+cc sky in case there is good reason we can't ignore invalid URLs when decoding ...

11 years, 2 months ago (2009-10-16 03:20:59 UTC) #2

ChrisCampbell

On 2009/10/16 03:20:59, timsteele wrote: > http://codereview.chromium.org/282004/diff/1/2#newcode241 > Line 241: if (!node && url.is_valid()) > ...

11 years, 2 months ago (2009-10-16 03:54:10 UTC) #4

tim (not reviewing)

11 years, 1 month ago (2009-10-30 00:36:51 UTC) #6

On 2009/10/29 22:13:52, timsteele wrote:
> LGTM

landed http://src.chromium.org/viewvc/chrome?view=rev&revision=30540