Fix for crash when a bookmark URL is an empty string...

chrome/browser/bookmarks/bookmark_codec.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_codec.h"
 
 #include <algorithm>
 
 #include "app/l10n_util.h"
 #include "base/string_util.h"
@@ skipping 219 matching lines @@
     return false;
 
   if (type_string != kTypeURL && type_string != kTypeFolder)
     return false;  // Unknown type.
 
   if (type_string == kTypeURL) {
     std::wstring url_string;
     if (!value.GetString(kURLKey, &url_string))
       return false;
 
-    if (!node)
-      node = new BookmarkNode(id, GURL(WideToUTF8(url_string)));
+    GURL url = GURL(WideToUTF8(url_string));
+    if (!node && url.is_valid())

[tim (not reviewing), 2009/10/16 03:20:59]

does this affect about: urls?  e.g about:memory?

+      node = new BookmarkNode(id, url);
     else
       return false;  // Node invalid.
 
     if (parent)
       parent->Add(parent->GetChildCount(), node);
     node->SetType(BookmarkNode::URL);
     UpdateChecksumWithUrlNode(id_string, title, url_string);
   } else {
     std::wstring last_modified_date;
     if (!value.GetString(kDateModifiedKey, &last_modified_date))
@@ skipping 72 matching lines @@
 
 void BookmarkCodec::InitializeChecksum() {
   MD5Init(&md5_context_);
 }
 
 void BookmarkCodec::FinalizeChecksum() {
   MD5Digest digest;
   MD5Final(&digest, &md5_context_);
   computed_checksum_ = MD5DigestToBase16(digest);
 }