Issue 2819059: Narrow down to one generic error per action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2819059: Narrow down to one generic error per action. (Closed)

Created:
10 years, 5 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

Narrow down to one generic error per action. This way if we miss a spot for returning a more specific error code, we'll at least know which action failed. BUG=560 TEST=unit tests, gmerged and confirmed that the PostinstallRunner action still fails...

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename SwitchToActionSpecificCode to GetErrorCodeForAction. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -16 lines)			Patch
M	action_processor.h	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	update_attempter.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	update_attempter.cc	View	1	3 chunks	+40 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit http://codereview.chromium.org/2819059/diff/1/3 File update_attempter.cc (right): http://codereview.chromium.org/2819059/diff/1/3#newcode95 update_attempter.cc:95: ActionExitCode SwitchToActionSpecificCode(AbstractAction* action, somehow, 'switch' feels ...

10 years, 5 months ago (2010-07-20 21:51:59 UTC) #2

petkov

10 years, 5 months ago (2010-07-20 22:00:58 UTC) #3

Pushing...

http://codereview.chromium.org/2819059/diff/1/3
File update_attempter.cc (right):

http://codereview.chromium.org/2819059/diff/1/3#newcode95
update_attempter.cc:95: ActionExitCode
SwitchToActionSpecificCode(AbstractAction* action,
On 2010/07/20 21:51:59, adlr wrote:
> somehow, 'switch' feels to me like it implies side effects, like it's
switching
> something in the system. How do you feel about "ErrorCodeForAction()" as a
name?

Renamed to GetErrorCodeForAction().

Expand Messages | Collapse Messages