Issue 28186: Reverting key change (again); this breaks every keyboard layout test there is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28186: Reverting key change (again); this breaks every keyboard layout test there is... (Closed)

Created:
11 years, 10 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverting key change (again); this breaks every keyboard layout test there is. Will fix and recommit. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10469

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+305 lines, -338 lines)			Patch
M	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_view_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	webkit/glue/SConscript	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/event_conversion.cc	View	3 chunks	+161 lines, -11 lines	0 comments	Download
M	webkit/glue/glue.vcproj	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	webkit/glue/webinputevent.h	View	6 chunks	+34 lines, -66 lines	0 comments	Download
M	webkit/glue/webinputevent_linux.cc	View	5 chunks	+15 lines, -20 lines	0 comments	Download
M	webkit/glue/webinputevent_mac.mm	View	3 chunks	+17 lines, -45 lines	0 comments	Download
D	webkit/glue/webinputevent_utils.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	webkit/glue/webinputevent_utils.cc	View	1 chunk	+0 lines, -116 lines	0 comments	Download
M	webkit/glue/webinputevent_win.cc	View	4 chunks	+8 lines, -21 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	10 chunks	+29 lines, -16 lines	0 comments	Download
M	webkit/glue/webwidget_impl.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/event_sending_controller.cc	View	1 chunk	+3 lines, -7 lines	0 comments	Download
M	webkit/tools/test_shell/keyboard_unittest.cc	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	webkit/tools/test_shell/mac/webwidget_host.mm	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/webwidget_host_gtk.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awesome :-P

Expand Messages | Collapse Messages