Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/renderer_host/render_view_host.cc

Issue 28186: Reverting key change (again); this breaks every keyboard layout test there is... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_host/render_view_host.h" 5 #include "chrome/browser/renderer_host/render_view_host.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/gfx/native_widget_types.h" 10 #include "base/gfx/native_widget_types.h"
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
1199 void RenderViewHost::OnUserMetricsRecordAction(const std::wstring& action) { 1199 void RenderViewHost::OnUserMetricsRecordAction(const std::wstring& action) {
1200 UserMetrics::RecordComputedAction(action.c_str(), process()->profile()); 1200 UserMetrics::RecordComputedAction(action.c_str(), process()->profile());
1201 } 1201 }
1202 1202
1203 void RenderViewHost::UnhandledInputEvent(const WebInputEvent& event) { 1203 void RenderViewHost::UnhandledInputEvent(const WebInputEvent& event) {
1204 RenderViewHostDelegate::View* view = delegate_->GetViewDelegate(); 1204 RenderViewHostDelegate::View* view = delegate_->GetViewDelegate();
1205 if (view) { 1205 if (view) {
1206 // TODO(brettw) why do we have to filter these types of events here. Can't 1206 // TODO(brettw) why do we have to filter these types of events here. Can't
1207 // the renderer just send us the ones we care abount, or maybe the view 1207 // the renderer just send us the ones we care abount, or maybe the view
1208 // should be able to decide which ones it wants or not? 1208 // should be able to decide which ones it wants or not?
1209 if ((event.type == WebInputEvent::RAW_KEY_DOWN) || 1209 if ((event.type == WebInputEvent::KEY_DOWN) ||
1210 (event.type == WebInputEvent::KEY_DOWN) ||
1211 (event.type == WebInputEvent::CHAR)) { 1210 (event.type == WebInputEvent::CHAR)) {
1212 view->HandleKeyboardEvent( 1211 view->HandleKeyboardEvent(
1213 static_cast<const WebKeyboardEvent&>(event)); 1212 static_cast<const WebKeyboardEvent&>(event));
1214 } 1213 }
1215 } 1214 }
1216 } 1215 }
1217 1216
1218 void RenderViewHost::OnEnterOrSpace() { 1217 void RenderViewHost::OnEnterOrSpace() {
1219 delegate_->OnEnterOrSpace(); 1218 delegate_->OnEnterOrSpace();
1220 } 1219 }
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
1327 std::string event_arg) { 1326 std::string event_arg) {
1328 Send(new ViewMsg_PersonalizationEvent(routing_id(), event_name, event_arg)); 1327 Send(new ViewMsg_PersonalizationEvent(routing_id(), event_name, event_arg));
1329 } 1328 }
1330 #endif 1329 #endif
1331 1330
1332 void RenderViewHost::ForwardMessageFromExternalHost( 1331 void RenderViewHost::ForwardMessageFromExternalHost(
1333 const std::string& target, const std::string& message) { 1332 const std::string& target, const std::string& message) {
1334 Send(new ViewMsg_HandleMessageFromExternalHost(routing_id(), target, 1333 Send(new ViewMsg_HandleMessageFromExternalHost(routing_id(), target,
1335 message)); 1334 message));
1336 } 1335 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/renderer_host/render_widget_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698