Don't re-store deleted passwords on form submit on the Mac

Don't re-store deleted passwords on form submit on the Mac

Adds test coverage for the various update cases to make sure they are all handled correctly.
Also fixes a regression during the recent PasswordStore refactoring that caused the Mac implementation to run queries on the wrong thread (found by the new unit tests).

BUG=35603
TEST=See bug; other password update cases should continue to work as before.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51135

[TVL, 2010-06-29 02:45:41]

lg

http://codereview.chromium.org/2818035/diff/2001/3004
File chrome/browser/password_manager/password_store_mac_unittest.cc (right):

http://codereview.chromium.org/2818035/diff/2001/3004#newcode35
chrome/browser/password_manager/password_store_mac_unittest.cc:35:
ACTION(STLDeleteElements0) {
should these go in a namespace to not collide with any other test?

[Paweł Hajdan Jr., 2010-06-29 12:47:47]

Drive-by with a minor test comment.

http://codereview.chromium.org/2818035/diff/2001/3004
File chrome/browser/password_manager/password_store_mac_unittest.cc (right):

http://codereview.chromium.org/2818035/diff/2001/3004#newcode906
chrome/browser/password_manager/password_store_mac_unittest.cc:906:
file_util::Delete(db_file_, false);
Could you use ScopedTempDir instead?

[stuartmorgan, 2010-06-29 15:27:03]

http://codereview.chromium.org/2818035/diff/2001/3004
File chrome/browser/password_manager/password_store_mac_unittest.cc (right):

http://codereview.chromium.org/2818035/diff/2001/3004#newcode35
chrome/browser/password_manager/password_store_mac_unittest.cc:35:
ACTION(STLDeleteElements0) {
On 2010/06/29 02:45:41, TVL wrote:
> should these go in a namespace to not collide with any other test?

Done.

http://codereview.chromium.org/2818035/diff/2001/3004#newcode906
chrome/browser/password_manager/password_store_mac_unittest.cc:906:
file_util::Delete(db_file_, false);
On 2010/06/29 12:47:47, Paweł Hajdan Jr. wrote:
> Could you use ScopedTempDir instead?

Done.

[Paweł Hajdan Jr., 2010-06-29 15:41:03]

Code I commented in the drive-by LGTM.