Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/browser/password_manager/password_store_mac_internal.h

Issue 2818035: Don't re-store deleted passwords on form submit on the Mac (Closed)
Patch Set: Address comments Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_store_mac_internal.h
diff --git a/chrome/browser/password_manager/password_store_mac_internal.h b/chrome/browser/password_manager/password_store_mac_internal.h
index 223c20eaab79cbb6417a7d4a7f20a9937e3ecc2a..43ae5ad4d2a54a3f31ae49b7a350750f1c460903 100644
--- a/chrome/browser/password_manager/password_store_mac_internal.h
+++ b/chrome/browser/password_manager/password_store_mac_internal.h
@@ -40,6 +40,13 @@ class MacKeychainPasswordFormAdapter {
webkit_glue::PasswordForm* PasswordExactlyMatchingForm(
const webkit_glue::PasswordForm& query_form);
+ // Returns true if PasswordsMergeableWithForm would return any items. This is
+ // a separate method because calling PasswordsMergeableWithForm and checking
+ // the return count would require reading the passwords from the keychain,
+ // thus potentially triggering authorizaiton UI, whereas this won't.
+ bool HasPasswordsMergeableWithForm(
+ const webkit_glue::PasswordForm& query_form);
+
// Returns all keychain items of types corresponding to password forms.
std::vector<webkit_glue::PasswordForm*> GetAllPasswordFormPasswords();
« no previous file with comments | « chrome/browser/password_manager/password_store_mac.cc ('k') | chrome/browser/password_manager/password_store_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698