X64: A bunch of small fixes.

X64: A bunch of small fixes.
Make push/pop use emit_optional_rex32.
Fix bug in disassembler (swapped name of comisd/ucomisd).
Use fstp in FCmp macro.

[Rico, 2010-06-23 11:28:25]

LGTM with loop fixed.

http://codereview.chromium.org/2818026/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/2818026/diff/1/2#newcode381
src/x64/assembler-x64.cc:381: nop(9);
if delta is >= 9 this will never terminate

http://codereview.chromium.org/2818026/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/2818026/diff/1/3#newcode58
src/x64/assembler-x64.h:58: static inline bool uint_is_int32(uint64_t x) {
is_int32 to be consistent with the other methods?

http://codereview.chromium.org/2818026/diff/1/3#newcode60
src/x64/assembler-x64.h:60: return x < kMaxIntValue;
<= ?

http://codereview.chromium.org/2818026/diff/1/3#newcode67
src/x64/assembler-x64.h:67: 
Maybe use the same naming convention for the max and min values in the four
methods above (e.g., kMaxUInt32, kMinInt32, kMaxInt32).

[Lasse Reichstein, 2010-06-23 11:39:46]

http://codereview.chromium.org/2818026/diff/1/2
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/2818026/diff/1/2#newcode381
src/x64/assembler-x64.cc:381: nop(9);
Whoops, fixed.

http://codereview.chromium.org/2818026/diff/1/3
File src/x64/assembler-x64.h (right):

http://codereview.chromium.org/2818026/diff/1/3#newcode58
src/x64/assembler-x64.h:58: static inline bool uint_is_int32(uint64_t x) {
It differs from the other methods in that its argument doesn't allow all the
possible values that it could accept (negative int32's cannot be passed).
I think this was the reason for the different naming, but I can see it's not
obvious why it's named differently.

http://codereview.chromium.org/2818026/diff/1/3#newcode60
src/x64/assembler-x64.h:60: return x < kMaxIntValue;
Changed, and value changed to 0x7fffffff.

http://codereview.chromium.org/2818026/diff/1/3#newcode67
src/x64/assembler-x64.h:67: 
Done.

[Rico, 2010-06-23 11:43:37]

LGTM