Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: src/x64/disasm-x64.cc

Issue 2818026: X64: A bunch of small fixes. (Closed)
Patch Set: Addressed review comments. As discussed, also fix call/jmp. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1010 matching lines...) Expand 10 before | Expand all | Expand 10 after
1021 } else if (opcode == 0x7E) { 1021 } else if (opcode == 0x7E) {
1022 AppendToBuffer("mov%c %s,", 1022 AppendToBuffer("mov%c %s,",
1023 rex_w() ? 'q' : 'd', 1023 rex_w() ? 'q' : 'd',
1024 NameOfCPURegister(regop)); 1024 NameOfCPURegister(regop));
1025 current += PrintRightXMMOperand(current); 1025 current += PrintRightXMMOperand(current);
1026 } else { 1026 } else {
1027 const char* mnemonic = "?"; 1027 const char* mnemonic = "?";
1028 if (opcode == 0x57) { 1028 if (opcode == 0x57) {
1029 mnemonic = "xorpd"; 1029 mnemonic = "xorpd";
1030 } else if (opcode == 0x2E) { 1030 } else if (opcode == 0x2E) {
1031 mnemonic = "ucomisd";
1032 } else if (opcode == 0x2F) {
1031 mnemonic = "comisd"; 1033 mnemonic = "comisd";
1032 } else if (opcode == 0x2F) {
1033 mnemonic = "ucomisd";
1034 } else { 1034 } else {
1035 UnimplementedInstruction(); 1035 UnimplementedInstruction();
1036 } 1036 }
1037 AppendToBuffer("%s %s,", mnemonic, NameOfXMMRegister(regop)); 1037 AppendToBuffer("%s %s,", mnemonic, NameOfXMMRegister(regop));
1038 current += PrintRightXMMOperand(current); 1038 current += PrintRightXMMOperand(current);
1039 } 1039 }
1040 } 1040 }
1041 } else if (group_1_prefix_ == 0xF2) { 1041 } else if (group_1_prefix_ == 0xF2) {
1042 // Beginning of instructions with prefix 0xF2. 1042 // Beginning of instructions with prefix 0xF2.
1043 1043
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
1669 for (int i = 6 - static_cast<int>(pc - prev_pc); i >= 0; i--) { 1669 for (int i = 6 - static_cast<int>(pc - prev_pc); i >= 0; i--) {
1670 fprintf(f, " "); 1670 fprintf(f, " ");
1671 } 1671 }
1672 fprintf(f, " %s\n", buffer.start()); 1672 fprintf(f, " %s\n", buffer.start());
1673 } 1673 }
1674 } 1674 }
1675 1675
1676 } // namespace disasm 1676 } // namespace disasm
1677 1677
1678 #endif // V8_TARGET_ARCH_X64 1678 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/assembler-x64.cc ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698