Wire up resource bundles on the mac:...

Wire up resource bundles on the mac:
- compile resource_bundle
- add resource_bundle_mac by cloning the linux and using some NSBundle to find
  the files.
- enable resource bundles on the mac in the calling code.
- added script to app target to repack .pak files into larger chunks (chrome,
  theme, and localized bits).
- added script to copy repacked files into the app bundle.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10460

[Mark Mentovai, 2009-02-26 04:08:41]

lg tm, just a couple of nits.

http://codereview.chromium.org/28171/diff/1/6
File chrome/common/resource_bundle_mac.mm (right):

http://codereview.chromium.org/28171/diff/1/6#newcode7
Line 7: #include <Foundation/Foundation.h>
#import Cocoa headers.

http://codereview.chromium.org/28171/diff/1/6#newcode33
Line 33: base::DataPack* LoadResourceDataPack(NSString *name) {
There's no extra level of indentation in an namespace.

http://codereview.chromium.org/28171/diff/1/6#newcode34
Line 34: base::DataPack *resource_pack = NULL;
A pet peeve of mine is code that can't decide whether it wants to do type* v or
type *v.  You've flipped styles between the function declaration and the
variables.

http://codereview.chromium.org/28171/diff/1/6#newcode51
Line 51: }
At the end of the namespace:

}  // namespace

http://codereview.chromium.org/28171/diff/1/6#newcode55
Line 55: << "ignoring resource langage for cocoa's choice";
I have no idea what this message means or why it has anything to do with
pref_locale.size().  Care to expound?

http://codereview.chromium.org/28171/diff/1/9
File chrome/tools/mac_repack_grit_resources.sh (right):

http://codereview.chromium.org/28171/diff/1/9#newcode1
Line 1: #!/bin/sh
These scripts are OK, they don't apply directly as-is to the gyp build but I'll
figure that out tomorrow.

[TVL, 2009-02-26 12:25:34]

http://codereview.chromium.org/28171/diff/1/6
File chrome/common/resource_bundle_mac.mm (right):

http://codereview.chromium.org/28171/diff/1/6#newcode7
Line 7: #include <Foundation/Foundation.h>
On 2009/02/26 04:08:42, Mark Mentovai wrote:
> #import Cocoa headers.

done (we don't want the min needed headers?)

http://codereview.chromium.org/28171/diff/1/6#newcode33
Line 33: base::DataPack* LoadResourceDataPack(NSString *name) {
On 2009/02/26 04:08:42, Mark Mentovai wrote:
> There's no extra level of indentation in an namespace.

Done.

http://codereview.chromium.org/28171/diff/1/6#newcode34
Line 34: base::DataPack *resource_pack = NULL;
On 2009/02/26 04:08:42, Mark Mentovai wrote:
> A pet peeve of mine is code that can't decide whether it wants to do type* v
or
> type *v.  You've flipped styles between the function declaration and the
> variables.

Done.

http://codereview.chromium.org/28171/diff/1/6#newcode51
Line 51: }
On 2009/02/26 04:08:42, Mark Mentovai wrote:
> At the end of the namespace:
> 
> }  // namespace

Done.

http://codereview.chromium.org/28171/diff/1/6#newcode55
Line 55: << "ignoring resource langage for cocoa's choice";
On 2009/02/26 04:08:42, Mark Mentovai wrote:
> I have no idea what this message means or why it has anything to do with
> pref_locale.size().  Care to expound?

Done.

http://codereview.chromium.org/28171/diff/1/9
File chrome/tools/mac_repack_grit_resources.sh (right):

http://codereview.chromium.org/28171/diff/1/9#newcode1
Line 1: #!/bin/sh
On 2009/02/26 04:08:42, Mark Mentovai wrote:
> These scripts are OK, they don't apply directly as-is to the gyp build but
I'll
> figure that out tomorrow.

Yea, rather then try to make them more fancy to handle deps, etc. I went simple
until I knew how to make them work in both worlds.