Small tweaks to improve toolbar keyboard accessibility: Put focus rects...

chrome/browser/views/location_bar/location_bar_view.h

Index: chrome/browser/views/location_bar/location_bar_view.h
===================================================================
--- chrome/browser/views/location_bar/location_bar_view.h	(revision 50343)
+++ chrome/browser/views/location_bar/location_bar_view.h	(working copy)
@@ -59,6 +59,9 @@
                         public views::DragController,
                         public AutocompleteEditController {
  public:
+  // The location bar view's class name.
+  static const char kViewClassName[];
+
   class Delegate {
    public:
     // Should return the current tab contents.
@@ -150,6 +153,13 @@
   // to close its popup.
   virtual void VisibleBoundsInRootChanged();
 
+  // Set if we should show a focus rect while the location entry field is
+  // focused. Used when the toolbar is in full keyboard accessibility mode.
+  void set_show_focus_rect(bool show) {

[sky, 2010/06/21 20:55:32]

Since you've got a SchedulePaint in here, it's no longer cheap and should be
SetShowFocusRect.

+    show_focus_rect_ = show;
+    SchedulePaint();
+  }
+
 #if defined(OS_WIN)
   // Event Handlers
   virtual bool OnMousePressed(const views::MouseEvent& event);
@@ -170,6 +180,7 @@
   virtual std::wstring GetTitle() const;
 
   // Overridden from views::View:
+  virtual std::string GetClassName() const;
   virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e);
   virtual bool GetAccessibleRole(AccessibilityTypes::Role* role);
 
@@ -343,6 +354,10 @@
   // We should actually be hidden iff this is greater than zero.
   int force_hidden_count_;
 
+  // True if we should show a focus rect while the location entry field is
+  // focused. Used when the toolbar is in full keyboard accessibility mode.
+  bool show_focus_rect_;
+
   // Used schedule a task for the first run info bubble.
   ScopedRunnableMethodFactory<LocationBarView> first_run_bubble_;