Small tweaks to improve toolbar keyboard accessibility: Put focus rects...

chrome/browser/views/location_bar/location_bar_view.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 #define CHROME_BROWSER_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 41 matching lines @@
 //   The LocationBarView class is a View subclass that paints the background
 //   of the URL bar strip and contains its content.
 //
 /////////////////////////////////////////////////////////////////////////////
 class LocationBarView : public LocationBar,
                         public LocationBarTesting,
                         public views::View,
                         public views::DragController,
                         public AutocompleteEditController {
  public:
+  // The location bar view's class name.
+  static const char kViewClassName[];
+
   class Delegate {
    public:
     // Should return the current tab contents.
     virtual TabContents* GetTabContents() = 0;
 
     // Called by the location bar view when the user starts typing in the edit.
     // This forces our security style to be UNKNOWN for the duration of the
     // editing.
     virtual void OnInputInProgress(bool in_progress) = 0;
   };
@@ skipping 71 matching lines @@
   virtual void Layout();
   virtual void Paint(gfx::Canvas* canvas);
 
   // No focus border for the location bar, the caret is enough.
   virtual void PaintFocusBorder(gfx::Canvas* canvas) { }
 
   // Called when any ancestor changes its size, asks the AutocompleteEditModel
   // to close its popup.
   virtual void VisibleBoundsInRootChanged();
 
+  // Set if we should show a focus rect while the location entry field is
+  // focused. Used when the toolbar is in full keyboard accessibility mode.
+  void set_show_focus_rect(bool show) {

[sky, 2010/06/21 20:55:32]

Since you've got a SchedulePaint in here, it's no longer cheap and should be
SetShowFocusRect.

+    show_focus_rect_ = show;
+    SchedulePaint();
+  }
+
 #if defined(OS_WIN)
   // Event Handlers
   virtual bool OnMousePressed(const views::MouseEvent& event);
   virtual bool OnMouseDragged(const views::MouseEvent& event);
   virtual void OnMouseReleased(const views::MouseEvent& event, bool canceled);
 #endif
 
   // AutocompleteEditController
   virtual void OnAutocompleteAccept(const GURL& url,
                                     WindowOpenDisposition disposition,
                                     PageTransition::Type transition,
                                     const GURL& alternate_nav_url);
   virtual void OnChanged();
   virtual void OnInputInProgress(bool in_progress);
   virtual void OnKillFocus();
   virtual void OnSetFocus();
   virtual SkBitmap GetFavIcon() const;
   virtual std::wstring GetTitle() const;
 
   // Overridden from views::View:
+  virtual std::string GetClassName() const;
   virtual bool SkipDefaultKeyEventProcessing(const views::KeyEvent& e);
   virtual bool GetAccessibleRole(AccessibilityTypes::Role* role);
 
   // Overridden from views::DragController:
   virtual void WriteDragData(View* sender,
                              const gfx::Point& press_pt,
                              OSExchangeData* data);
   virtual int GetDragOperations(View* sender, const gfx::Point& p);
   virtual bool CanStartDrag(View* sender,
                             const gfx::Point& press_pt,
@@ skipping 153 matching lines @@
   // The star.
   StarView* star_view_;
 
   // The mode that dictates how the bar shows.
   Mode mode_;
 
   // Counts the number of times consumers have asked us to be hidden.
   // We should actually be hidden iff this is greater than zero.
   int force_hidden_count_;
 
+  // True if we should show a focus rect while the location entry field is
+  // focused. Used when the toolbar is in full keyboard accessibility mode.
+  bool show_focus_rect_;
+
   // Used schedule a task for the first run info bubble.
   ScopedRunnableMethodFactory<LocationBarView> first_run_bubble_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(LocationBarView);
 };
 
 #endif  // CHROME_BROWSER_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_