Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/views/accessible_toolbar_view.h

Issue 2817022: Small tweaks to improve toolbar keyboard accessibility: Put focus rects... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/views/accessible_toolbar_view.h
===================================================================
--- chrome/browser/views/accessible_toolbar_view.h (revision 50343)
+++ chrome/browser/views/accessible_toolbar_view.h (working copy)
@@ -31,13 +31,13 @@
// if the user escapes. If |initial_focus| is not NULL, that control will get
// the initial focus, if it's enabled and focusable. Returns true if
// the toolbar was able to receive focus.
- bool SetToolbarFocus(int view_storage_id, View* initial_focus);
+ virtual bool SetToolbarFocus(int view_storage_id, View* initial_focus);
// Set focus to the toolbar with complete keyboard access, with the
// focus initially set to the default child. Focus will be restored
// to the ViewStorage with id |view_storage_id| if the user escapes.
// Returns true if the toolbar was able to receive focus.
- bool SetToolbarFocusAndFocusDefault(int view_storage_id);
+ virtual bool SetToolbarFocusAndFocusDefault(int view_storage_id);
// Overridden from views::View:
virtual FocusTraversable* GetPaneFocusTraversable();
@@ -59,12 +59,13 @@
// other than the first focusable child.
virtual views::View* GetDefaultFocusableChild() { return NULL; }
+ // Remove toolbar focus.
+ virtual void RemoveToolbarFocus();
+
// Remove toolbar focus unless a child (including indirect children)
// still has the focus.
void RemoveToolbarFocusIfNoChildHasFocus();
- void RemoveToolbarFocus();
-
void RestoreLastFocusedView();
View* GetFirstFocusableChild();

Powered by Google App Engine
This is Rietveld 408576698