Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 28144: Implement the NTLM authentication scheme by porting... (Closed)

Created:
11 years, 10 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Implement the NTLM authentication scheme by porting Mozilla's implementation. R=darin,eroman BUG=6567, 6824 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10667

Patch Set 1 #

Patch Set 2 : Ready for review. Unit tests to do. #

Total comments: 19

Patch Set 3 : Address eroman's review comments #

Patch Set 4 : '' #

Total comments: 18

Patch Set 5 : Address eroman's review comments on Patch Set 4 #

Patch Set 6 : Upload before checkin #

Patch Set 7 : Upload before checkin #

Patch Set 8 : Final upload before checkin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1786 lines, -42 lines) Patch
M net/build/net.vcproj View 1 2 3 4 5 6 7 3 chunks +24 lines, -0 lines 0 comments Download
M net/build/net_unittests.vcproj View 1 2 3 4 5 6 7 2 chunks +6 lines, -2 lines 0 comments Download
A net/http/des.h View 1 2 1 chunk +27 lines, -0 lines 0 comments Download
A net/http/des.cc View 1 2 3 4 5 1 chunk +220 lines, -0 lines 0 comments Download
A net/http/des_unittest.cc View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
M net/http/http_auth.h View 4 5 6 7 2 chunks +9 lines, -2 lines 0 comments Download
M net/http/http_auth.cc View 1 2 3 4 5 6 7 7 chunks +25 lines, -8 lines 0 comments Download
M net/http/http_auth_cache_unittest.cc View 1 2 3 4 5 6 7 7 chunks +10 lines, -9 lines 0 comments Download
M net/http/http_auth_handler.h View 1 2 3 4 5 6 7 4 chunks +33 lines, -5 lines 0 comments Download
M net/http/http_auth_handler.cc View 1 2 3 4 5 6 7 1 chunk +6 lines, -4 lines 0 comments Download
M net/http/http_auth_handler_basic.cc View 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_auth_handler_digest.cc View 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A net/http/http_auth_handler_ntlm.h View 1 2 3 4 1 chunk +60 lines, -0 lines 0 comments Download
A net/http/http_auth_handler_ntlm.cc View 1 2 3 4 1 chunk +787 lines, -0 lines 0 comments Download
M net/http/http_auth_unittest.cc View 2 3 4 5 6 7 5 chunks +83 lines, -3 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 2 3 4 5 6 7 4 chunks +32 lines, -9 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 5 6 7 1 chunk +125 lines, -0 lines 0 comments Download
A net/http/md4.h View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A net/http/md4.cc View 1 2 1 chunk +184 lines, -0 lines 0 comments Download
M net/net.xcodeproj/project.pbxproj View 1 2 3 4 5 6 7 10 chunks +22 lines, -0 lines 0 comments Download
M net/net_lib.scons View 1 2 3 4 5 6 7 3 chunks +6 lines, -0 lines 0 comments Download
M net/net_unittests.scons View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wtc
eroman: please review the entire CL. darin: please review at the high level. I will ...
11 years, 10 months ago (2009-02-26 01:00:47 UTC) #1
eroman
First pass. I will have some higher level comments on http_network_transaction.cc for you tommorow. I ...
11 years, 10 months ago (2009-02-26 08:53:47 UTC) #2
wtc
Eric: Please review Patch Set 4. Note that three files are newly added to the ...
11 years, 9 months ago (2009-02-27 03:25:03 UTC) #3
eroman
note, I had a hard time parsing the code in http_auth_handler_ntlm.cc will be good once ...
11 years, 9 months ago (2009-02-27 06:02:03 UTC) #4
eroman
Is there any safeguard against infinite transactopm restarts? (i.e. what happens if the server continually ...
11 years, 9 months ago (2009-02-27 06:07:23 UTC) #5
darin (slow to review)
The approach looks great to me. +1 for moving the crypto code into base. http://codereview.chromium.org/28144/diff/1092/70 ...
11 years, 9 months ago (2009-02-27 17:30:57 UTC) #6
darin (slow to review)
though maybe it is time for us to create a base/crypto/ directory.
11 years, 9 months ago (2009-02-27 17:31:16 UTC) #7
wtc
Eric: Thanks for the review. Please review Patch Set 5. I addressed all of your ...
11 years, 9 months ago (2009-02-28 00:15:35 UTC) #8
eroman
11 years, 9 months ago (2009-02-28 00:20:11 UTC) #9
LGTM

Powered by Google App Engine
This is Rietveld 408576698