Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: net/http/http_auth.h

Issue 28144: Implement the NTLM authentication scheme by porting... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Final upload before checkin Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/des_unittest.cc ('k') | net/http/http_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth.h
===================================================================
--- net/http/http_auth.h (revision 10666)
+++ net/http/http_auth.h (working copy)
@@ -53,6 +53,7 @@
IdentitySource source;
bool invalid;
+ // TODO(wtc): |username| and |password| should be string16.
std::wstring username;
std::wstring password;
};
@@ -74,8 +75,14 @@
// Iterate through the challenge headers, and pick the best one that
// we support. Obtains the implementation class for handling the challenge,
- // and passes it back in |*handler|. If no supported challenge was found
- // |*handler| is set to NULL.
+ // and passes it back in |*handler|. If the existing handler in |*handler|
+ // should continue to be used (such as for the NTLM authentication scheme),
+ // |*handler| is unchanged. If no supported challenge was found, |*handler|
+ // is set to NULL.
+ //
+ // TODO(wtc): Continuing to use the existing handler in |*handler| (for
+ // NTLM) is new behavior. Rename ChooseBestChallenge to fully encompass
+ // what it does now.
static void ChooseBestChallenge(const HttpResponseHeaders* headers,
Target target,
scoped_refptr<HttpAuthHandler>* handler);
« no previous file with comments | « net/http/des_unittest.cc ('k') | net/http/http_auth.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698