Issue 2813060: Gtk: Set default focus to the close button in the clear browsing data dialog....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2813060: Gtk: Set default focus to the close button in the clear browsing data dialog.... (Closed)

Created:
10 years, 5 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Evan Stade

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Gtk: Set default focus to the close button in the clear browsing data dialog. BUG=21461 TEST=GTK dialog matches Windows dialog. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52815

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/gtk/clear_browsing_data_dialog_gtk.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

Even though http://codereview.chromium.org/201080 set GetDefaultDialogButton() to return MessageBoxFlags::DIALOGBUTTON_NONE, on Windows/5.0.375.99, the default button in the ...

10 years, 5 months ago (2010-07-17 00:41:36 UTC) #1

Mark Mentovai

10 years, 5 months ago (2010-07-17 02:28:38 UTC) #3

LGTM. Although I’m always happy to review any code anywhere in the project, I’m
not sure why I was included on this one.

Expand Messages | Collapse Messages