Issue 201080: [Windows] Clear Browsing Data dialog should not have any button as default action.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201080: [Windows] Clear Browsing Data dialog should not have any button as default action. (Closed)

Created:
11 years, 3 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Glen Murphy

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

[Windows] Clear Browsing Data dialog should not have any button as default action. Also makes the behavior in Windows side act the same as in Linux/Mac. BUG=21461 TEST=open "clear browsing data" and see if none of buttons are set as default. Committed r25992

Patch Set 1 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/views/clear_browsing_data.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	chrome/browser/views/clear_browsing_data.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

On the Mac, I made neither button be default. Is that possible with views?

11 years, 3 months ago (2009-09-10 16:36:42 UTC) #2

tfarina (gmail-do not use)

Mark, now it works in the same way as in Mac/Linux.

11 years, 3 months ago (2009-09-10 19:21:47 UTC) #3

tfarina (gmail-do not use)

11 years, 3 months ago (2009-09-11 18:41:59 UTC) #5

On 2009/09/10 19:23:16, Mark Mentovai wrote:
> Looks good
Can you land this to me?

Expand Messages | Collapse Messages