Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2813047: Move default_plugin from webkit/ to chrome/ (Closed)

Created:
10 years, 5 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org, dpranke+watch_chromium.org, John Grabowski, jam, pam+watch_chromium.org
Visibility:
Public.

Description

Move default_plugin from webkit/ to chrome/ Second try, first try at http://codereview.chromium.org/2803035 . Also contains http://codereview.chromium.org/2838044 , changes to DEPS files (mostly cleanups), and a change to webkit/glue/plugins/webplugin_delegate_impl_win.cc . BUG=48419 TEST=everything still builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51692

Patch Set 1 #

Patch Set 2 : new try #

Patch Set 3 : fix windows? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -82 lines) Patch
M chrome/app/chrome_dll.rc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugin_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/default_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/default_plugin/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A + chrome/default_plugin/default_plugin.gyp View 2 chunks +9 lines, -12 lines 0 comments Download
A + chrome/default_plugin/default_plugin_resources.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/default_plugin/default_plugin_resources.rc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/default_plugin/install_dialog.h View 2 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/default_plugin/install_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/default_plugin/plugin_database_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_database_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_impl_gtk.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_impl_gtk.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_impl_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_impl_mac.mm View 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/default_plugin/plugin_impl_win.h View 2 3 chunks +6 lines, -7 lines 0 comments Download
A + chrome/default_plugin/plugin_impl_win.cc View 2 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/default_plugin/plugin_install_job_monitor.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_install_job_monitor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/default_plugin/plugin_main.h View 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/default_plugin/plugin_main.cc View 2 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/default_plugin/plugins.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/default_plugin/plugins2.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 2 chunks +1 line, -1 line 0 comments Download
D webkit/default_plugin/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
A + webkit/glue/plugins/default_plugin_shared.h View 2 2 chunks +8 lines, -3 lines 0 comments Download
M webkit/glue/plugins/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/plugins/webplugin_delegate_impl_win.cc View 2 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
The last try turned the waterfall red. This time it hopefully works. The CL mostly ...
10 years, 5 months ago (2010-07-07 04:57:43 UTC) #1
tony
10 years, 5 months ago (2010-07-07 15:18:13 UTC) #2 
LG

Powered by Google App Engine
This is Rietveld 408576698