Move default_plugin out of webkit.

Move default_plugin out of webkit.

BUG=48419
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51681

[tony, 2010-07-06 22:51:26]

Nice, LGTM!

I'm not super thrilled with the location.  Maybe
src/chrome/plugins/default_plugin or src/chrome/default_plugin would be better
(since only chrome targets depend on default_plugin).  What do you think?

http://codereview.chromium.org/2803035/diff/17001/18008
File default_plugin/default_plugin.gyp (right):

http://codereview.chromium.org/2803035/diff/17001/18008#newcode14
default_plugin/default_plugin.gyp:14: '../net/net.gyp:net_resources',
FYI: If you change these to <(DEPTH)/net/net.gyp:net_resources, it'll work no
matter where you move this directory.  It's ok as ../ as well.

http://codereview.chromium.org/2803035/diff/17001/18028
File webkit/glue/plugins/default_plugin_shared.h (right):

http://codereview.chromium.org/2803035/diff/17001/18028#newcode8
webkit/glue/plugins/default_plugin_shared.h:8: #ifndef
DEFAULT_PLUGIN_DEFAULT_PLUGIN_SHARED_H
Nit: WEBKIT_GLUE_PLUGINS_DEFAULT_PLUGIN_SHARED_H

http://codereview.chromium.org/2803035/diff/17001/18032
File webkit/tools/test_shell/test_shell.gypi (left):

http://codereview.chromium.org/2803035/diff/17001/18032#oldcode162
webkit/tools/test_shell/test_shell.gypi:162:
'<(DEPTH)/webkit/default_plugin/default_plugin.gyp:default_plugin',
Nice!  I assume this means default_plugin doesn't work in test_shell now, but
maybe it was already broken.

[Nico, 2010-07-06 22:57:04]

Ok, I'll move it to chrome (chrome/plugin seems to be the plugin process stuff,
so it doesn't really fit there imho). Thanks for the <(DEPTH) tip :-)

http://codereview.chromium.org/2803035/diff/17001/18032
File webkit/tools/test_shell/test_shell.gypi (left):

http://codereview.chromium.org/2803035/diff/17001/18032#oldcode162
webkit/tools/test_shell/test_shell.gypi:162:
'<(DEPTH)/webkit/default_plugin/default_plugin.gyp:default_plugin',
On 2010/07/06 22:51:26, tony wrote:
> Nice!  I assume this means default_plugin doesn't work in test_shell now, but
> maybe it was already broken.

That never worked (or didn't in a long time):

  // We don't want the null plugin to work in the following cases:-
  // 1. Test-shell
  // 2. The plugin is running in the renderer process.
  if (webkit_glue::IsPluginRunningInRendererProcess()) {
    return NPERR_GENERIC_ERROR;
  }

(from
http://www.google.com/codesearch/p?hl=en#hfE6470xZHk/webkit/default_plugin/pl...
)

[Nico, 2010-07-06 23:11:55]

Moved.

[tony, 2010-07-06 23:26:03]

LGTM with the fixes below.  Please wait for the try bots to succeed.

http://codereview.chromium.org/2803035/diff/16002/22010
File chrome/default_plugin/install_dialog.cc (right):

http://codereview.chromium.org/2803035/diff/16002/22010#newcode11
chrome/default_plugin/install_dialog.cc:11: #include
"default_plugin/plugin_impl.h"
This doesn't look right...

http://codereview.chromium.org/2803035/diff/16002/22020
File chrome/default_plugin/plugin_impl_win.h (right):

http://codereview.chromium.org/2803035/diff/16002/22020#newcode13
chrome/default_plugin/plugin_impl_win.h:13: #include
"default_plugin/install_dialog.h"
These probably need to be updated too.