Issue 2813016: Fix use of up and down arrows when the candidate window is not visible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2813016: Fix use of up and down arrows when the candidate window is not visible. (Closed)

Created:
10 years, 6 months ago by Zachary Kuznia

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org/ibus-chewing.git

Visibility:
Public.

Description

Fix use of up and down arrows when the candidate window is not visible. BUG=chromium-os:4107 TEST=Set the IME to chewing, type 'hol', press space, press down. Ensure that the candidate window appears, and it does not hang.

Patch Set 1 #

Patch Set 2 : Code Review #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -10 lines)			Patch
	M	src/IBusChewingEngine.gob	View		1 chunk	+18 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

satorux1

10 years, 6 months ago (2010-06-17 03:24:38 UTC) #2

LGTM

Please upstream this too.
On 2010/06/17 02:24:16, Zachary Kuznia wrote:
>

Expand Messages | Collapse Messages