Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: src/IBusChewingEngine.gob

Issue 2813016: Fix use of up and down arrows when the candidate window is not visible. (Closed) Base URL: ssh://gitrw.chromium.org/ibus-chewing.git
Patch Set: Code Review Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 requires 2.0.0 1 requires 2.0.0
2 2
3 %alltop{ 3 %alltop{
4 /* 4 /*
5 * Copyright © 2009 Red Hat, Inc. All rights reserved. 5 * Copyright © 2009 Red Hat, Inc. All rights reserved.
6 * Copyright © 2009 Ding-Yi Chen <dchen at redhat.com> 6 * Copyright © 2009 Ding-Yi Chen <dchen at redhat.com>
7 * 7 *
8 * This file is part of the ibus-chewing Project. 8 * This file is part of the ibus-chewing Project.
9 * 9 *
10 * This program is free software; you can redistribute it and/or 10 * This program is free software; you can redistribute it and/or
(...skipping 923 matching lines...) Expand 10 before | Expand all | Expand 10 after
934 override (IBus:Engine) void 934 override (IBus:Engine) void
935 page_down(IBus:Engine *engine){ 935 page_down(IBus:Engine *engine){
936 Self *self=SELF(engine); 936 Self *self=SELF(engine);
937 chewing_handle_PageDown(self->context); 937 chewing_handle_PageDown(self->context);
938 self_update(self); 938 self_update(self);
939 } 939 }
940 940
941 override (IBus:Engine) void 941 override (IBus:Engine) void
942 cursor_up(IBus:Engine *engine){ 942 cursor_up(IBus:Engine *engine){
943 Self *self=SELF(engine); 943 Self *self=SELF(engine);
944 » //chewing_handle_Up(self->context); 944 » if (self->tableVisible){
945 » self_cursor_prev(self); 945 » self_cursor_prev(self);
946 » self_update(self); 946 » self_update(self);
947 » ibus_lookup_table_set_cursor_pos(self->table, self->tableCursor); 947 » ibus_lookup_table_set_cursor_pos(self->table, self->tableCursor);
948 » ibus_engine_update_lookup_table(IBUS_ENGINE(self),self->table,TRUE); 948 » ibus_engine_update_lookup_table(IBUS_ENGINE(self),self->table,TRUE);
949 » } else {
950 » chewing_handle_Up(self->context);
951 » self_update(self);
952 » }
949 } 953 }
950 954
951 override (IBus:Engine) void 955 override (IBus:Engine) void
952 cursor_down(IBus:Engine *engine){ 956 cursor_down(IBus:Engine *engine){
953 Self *self=SELF(engine); 957 Self *self=SELF(engine);
954 » //chewing_handle_Down(self->context); 958 » if (self->tableVisible){
955 » self_cursor_next(self); 959 » self_cursor_next(self);
956 » self_update(self); 960 » self_update(self);
957 » ibus_lookup_table_set_cursor_pos(self->table, self->tableCursor); 961 » ibus_lookup_table_set_cursor_pos(self->table, self->tableCursor);
958 » ibus_engine_update_lookup_table(IBUS_ENGINE(self),self->table,TRUE); 962 » ibus_engine_update_lookup_table(IBUS_ENGINE(self),self->table,TRUE);
963 » } else {
964 » chewing_handle_Down(self->context);
965 » self_update(self);
966 » }
959 } 967 }
960 968
961 override (IBus:Engine) void 969 override (IBus:Engine) void
962 enable(IBus:Engine *engine){ 970 enable(IBus:Engine *engine){
963 G_DEBUG_MSG(2,"[I2] enable()"); 971 G_DEBUG_MSG(2,"[I2] enable()");
964 Self *self=SELF(engine); 972 Self *self=SELF(engine);
965 973
966 if (!self->config){ 974 if (!self->config){
967 975
968 /* connections_list is not avail in init, so we put it here */ 976 /* connections_list is not avail in init, so we put it here */
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
1072 IBusProperty *prop=self_get_iBusProperty(self, prop_name); 1080 IBusProperty *prop=self_get_iBusProperty(self, prop_name);
1073 ibus_property_set_visible(prop,FALSE); 1081 ibus_property_set_visible(prop,FALSE);
1074 ibus_engine_update_property(engine,prop); 1082 ibus_engine_update_property(engine,prop);
1075 } 1083 }
1076 } 1084 }
1077 1085
1078 %{ 1086 %{
1079 #include "IBusChewingEngine-keys.c" 1087 #include "IBusChewingEngine-keys.c"
1080 %} 1088 %}
1081 1089
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698