Issue 2813005: Avoid a crash when current version info is not obtainable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2813005: Avoid a crash when current version info is not obtainable. (Closed)

Created:
10 years, 6 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Lei Zhang, tony

CC:
chromium-reviews, kuchhal, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Avoid a crash when installed version info is not obtainable. I'm pretty sure the problem is due to users downgrading to versions where --product-version is not available. See the bug for more details. BUG=46547 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49824

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : oops #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	chrome/browser/upgrade_detector.cc	View	1 2	1 chunk	+12 lines, -3 lines	0 comments	Download
	M	chrome/installer/util/version.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

LGTM, since crashing sucks. I'm not 100% convinced you should suggest a restart, but I ...

10 years, 6 months ago (2010-06-15 04:25:20 UTC) #3

LGTM

Expand Messages | Collapse Messages