chrome/installer/util/version.cc - Issue 2813005: Avoid a crash when current version info is not obtainable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/version.cc

Issue 2813005: Avoid a crash when current version info is not obtainable. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: oops Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/version.cc

diff --git a/chrome/installer/util/version.cc b/chrome/installer/util/version.cc

index 2e580763de44138813eea6b78fa97fa86cc1ab3e..6dfc2058a297e94a935524f57882ed440205523e 100644

--- a/chrome/installer/util/version.cc

+++ b/chrome/installer/util/version.cc

@@ -38,6 +38,7 @@ installer::Version* installer::Version::GetVersionFromString(

SplitString(version_str, '.', &numbers);

if (numbers.size() != 4) {

+ LOG(ERROR) << "Invalid version string: " << version_str;

return NULL;

}

« no previous file with comments | « chrome/browser/upgrade_detector.cc ('k') | no next file » | no next file with comments »