Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2811032: Revert 50784 - Canvas refactoring part 3.... (Closed)

Created:
10 years, 6 months ago by Ben Goodger (Google)
Modified:
9 years, 6 months ago
CC:
chromium-reviews, jam+cc_chromium.org, Paul Godavari, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paweł Hajdan Jr., Aaron Boodman, darin-cc_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 50784 - Canvas refactoring part 3. - Replace Canvas instance users with CanvasSkia users. - Rename Canvas2 to Canvas. - Delete Canvas subclass of CanvasSkia. This has created some ugliness around the fact that people that used SkCanvas methods on Canvas now have to go through AsCanvasSkia first. This is temporary ugliness that will be eradicated as I incrementally build out the new Canvas API. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825018 TBR=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+305 lines, -497 lines) Patch
M chrome/browser/chromeos/status/network_menu_button.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_util.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/autocomplete/autocomplete_popup_contents_view.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/views/browser_actions_container.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bubble_border.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/create_application_shortcut_view.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/views/detachable_toolbar_view.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/views/download_item_view.cc View 6 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/views/extensions/browser_action_overflow_menu_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/extensions/extension_shelf.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/views/frame/opaque_browser_frame_view.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/views/fullscreen_exit_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/info_bubble.cc View 2 chunks +2 lines, -2 lines 0 comments Download
MM chrome/browser/views/infobars/translate_infobar_base.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/views/infobars/translate_infobars.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/views/list_background.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/location_bar/location_bar_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/views/notifications/balloon_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/options/fonts_page_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/sad_tab_view.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/views/status_bubble_views.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/tabs/base_tab.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_view.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/native_view_photobooth_win.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/views/tabs/side_tab.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/browser/views/tabs/tab.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/views/theme_install_bubble_view.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/extensions/extension_action.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M gfx/canvas.h View 1 chunk +14 lines, -182 lines 0 comments Download
A + gfx/canvas_2.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M gfx/canvas_skia.h View 4 chunks +3 lines, -7 lines 0 comments Download
M gfx/canvas_skia.cc View 5 chunks +18 lines, -25 lines 0 comments Download
M gfx/canvas_skia_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M gfx/canvas_skia_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M gfx/canvas_skia_paint.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gfx/canvas_skia_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M gfx/font_mac.mm View 2 chunks +2 lines, -3 lines 0 comments Download
M gfx/font_skia.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M gfx/font_win.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M gfx/gfx.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M views/background.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/button/text_button.cc View 4 chunks +12 lines, -11 lines 0 comments Download
M views/controls/label.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/controls/menu/menu_item_view_gtk.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M views/controls/menu/menu_item_view_win.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M views/controls/menu/menu_scroll_view_container.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M views/controls/menu/menu_separator_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/progress_bar.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/controls/tabbed_pane/native_tabbed_pane_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M views/controls/table/table_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/drag_utils.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M views/drag_utils_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/painter.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M views/view.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M views/view_text_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M views/view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/root_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M views/widget/root_view_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M views/widget/widget_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M views/widget/widget_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M views/window/dialog_client_view.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Ben Goodger (Google)
10 years, 6 months ago (2010-06-24 23:51:44 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698