base/data_pack.h - Issue 2811016: Revert 50257 - Reland r50057. This is exactly the same except with two lines ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/data_pack.h

Issue 2811016: Revert 50257 - Reland r50057. This is exactly the same except with two lines ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/data_pack.h

===================================================================

--- base/data_pack.h (revision 50259)

+++ base/data_pack.h (working copy)

@@ -35,12 +35,12 @@

// Get resource by id |resource_id|, filling in |data|.

// The data is owned by the DataPack object and should not be modified.

// Returns false if the resource id isn't found.

- bool GetStringPiece(uint32 resource_id, StringPiece* data) const;

+ bool GetStringPiece(uint32 resource_id, StringPiece* data);

// Like GetStringPiece(), but returns a reference to memory. This interface

// is used for image data, while the StringPiece interface is usually used

// for localization strings.

- RefCountedStaticMemory* GetStaticMemory(uint32 resource_id) const;

+ RefCountedStaticMemory* GetStaticMemory(uint32 resource_id);

// Writes a pack file containing |resources| to |path|.

static bool WritePack(const FilePath& path,

« no previous file with comments | « app/resource_bundle.cc ('k') | base/data_pack.cc » ('j') | no next file with comments »