Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 28109: Issue 63: Running tests fails of there is a dot in the checkout path (Closed)

Created:
11 years, 10 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Issue 63: Running tests fails of there is a dot in the checkout path Patch by Matt Hanselman (http://codereview.chromium.org/27086). Pass in the module's filename while loading rather than the full path (so call to load_module now matches find_module). Otherwise dots in path name get mistaken for file suffixes. Added Matt Hanselman to AUTHORS file. BUG=63 Committed: http://code.google.com/p/v8/source/detail?r=1356

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-25 08:47:34 UTC) #1
Christian Plesner Hansen
11 years, 10 months ago (2009-02-25 10:08:50 UTC) #2
Lgtm

Powered by Google App Engine
This is Rietveld 408576698