Issue 27086: Issue 63: Running tests fails of there is a dot in the checkout path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27086: Issue 63: Running tests fails of there is a dot in the checkout path (Closed)

Created:
11 years, 10 months ago by Matt Hanselman

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Pass in the module's filename while loading rather than the full path (so call to load_module now matches find_module). Otherwise dots in path name get mistaken for file suffixes. BUG=63

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/test.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 10 months ago (2009-02-25 10:11:05 UTC) #2

LGTM

Comitted by sgjesse@chromium.org, see http://codereview.chromium.org/28109.

On 2009/02/24 13:18:11, mjhanselman wrote:
>

Expand Messages | Collapse Messages