Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: chrome_frame/test/no_interference_test.cc

Issue 2810045: Disable a crashing test: NoInterferenceTest.JavascriptWindowOpen (Closed)
Patch Set: Patch Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/no_interference_test.cc
diff --git a/chrome_frame/test/no_interference_test.cc b/chrome_frame/test/no_interference_test.cc
index 99bcc27e84a2482e91f4da3cbdab0a32e30f394a..533d2885c1f9919480fd602b9a4f900456d0ed3c 100644
--- a/chrome_frame/test/no_interference_test.cc
+++ b/chrome_frame/test/no_interference_test.cc
@@ -130,7 +130,9 @@ TEST_F(NoInterferenceTest, FLAKY_SimpleFocus) {
}
// Javascript window.open should open a new window with an IE renderer.
-TEST_F(NoInterferenceTest, FLAKY_JavascriptWindowOpen) {
+// Disabled because of crashes.
+// http://code.google.com/p/chromium/issues/detail?id=48175
+TEST_F(NoInterferenceTest, DISABLED_JavascriptWindowOpen) {
const std::wstring kWindowOpenUrl = GetTestUrl(L"window_open.html");
ComStackObjectWithUninitialize<
testing::StrictMock<MockWebBrowserEventSink> > new_window_mock;
@@ -266,4 +268,4 @@ TEST_F(NoInterferenceTest, FLAKY_SelectContextMenuOpenInNewWindow) {
LaunchIEAndNavigate(link_page_url());
}
-} // namespace
+} // namespace
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698