Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Side by Side Diff: chrome_frame/test/no_interference_test.cc

Issue 2810045: Disable a crashing test: NoInterferenceTest.JavascriptWindowOpen (Closed)
Patch Set: Patch Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_frame/test/test_mock_with_web_server.h" 5 #include "chrome_frame/test/test_mock_with_web_server.h"
6 6
7 #include "base/scoped_variant_win.h" 7 #include "base/scoped_variant_win.h"
8 #include "base/utf_string_conversions.h" 8 #include "base/utf_string_conversions.h"
9 #include "chrome_frame/test/simulate_input.h" 9 #include "chrome_frame/test/simulate_input.h"
10 #include "chrome_frame/test/test_with_web_server.h" 10 #include "chrome_frame/test/test_with_web_server.h"
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 EXPECT_CALL(mock_, OnIELoad(testing::StrCaseEq(empty_page_url()))) 123 EXPECT_CALL(mock_, OnIELoad(testing::StrCaseEq(empty_page_url())))
124 .WillOnce(testing::DoAll( 124 .WillOnce(testing::DoAll(
125 ExpectIERendererWindowHasFocus(&mock_), 125 ExpectIERendererWindowHasFocus(&mock_),
126 VerifyAddressBarUrl(&mock_), 126 VerifyAddressBarUrl(&mock_),
127 CloseBrowserMock(&mock_))); 127 CloseBrowserMock(&mock_)));
128 128
129 LaunchIEAndNavigate(empty_page_url()); 129 LaunchIEAndNavigate(empty_page_url());
130 } 130 }
131 131
132 // Javascript window.open should open a new window with an IE renderer. 132 // Javascript window.open should open a new window with an IE renderer.
133 TEST_F(NoInterferenceTest, FLAKY_JavascriptWindowOpen) { 133 // Disabled because of crashes.
134 // http://code.google.com/p/chromium/issues/detail?id=48175
135 TEST_F(NoInterferenceTest, DISABLED_JavascriptWindowOpen) {
134 const std::wstring kWindowOpenUrl = GetTestUrl(L"window_open.html"); 136 const std::wstring kWindowOpenUrl = GetTestUrl(L"window_open.html");
135 ComStackObjectWithUninitialize< 137 ComStackObjectWithUninitialize<
136 testing::StrictMock<MockWebBrowserEventSink> > new_window_mock; 138 testing::StrictMock<MockWebBrowserEventSink> > new_window_mock;
137 139
138 mock_.ExpectNavigationInIE(kWindowOpenUrl); 140 mock_.ExpectNavigationInIE(kWindowOpenUrl);
139 EXPECT_CALL(mock_, OnIELoad(testing::StrCaseEq(kWindowOpenUrl))) 141 EXPECT_CALL(mock_, OnIELoad(testing::StrCaseEq(kWindowOpenUrl)))
140 .WillOnce(testing::DoAll( 142 .WillOnce(testing::DoAll(
141 DelaySendMouseClickToIE(&mock_, &loop_, 0, 100, 100, 143 DelaySendMouseClickToIE(&mock_, &loop_, 0, 100, 100,
142 simulate_input::LEFT), 144 simulate_input::LEFT),
143 DelaySendMouseClickToIE(&mock_, &loop_, 0, 100, 100, 145 DelaySendMouseClickToIE(&mock_, &loop_, 0, 100, 100,
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 EXPECT_CALL(new_window_mock, 261 EXPECT_CALL(new_window_mock,
260 OnIELoad(testing::StrCaseEq(empty_page_url()))) 262 OnIELoad(testing::StrCaseEq(empty_page_url())))
261 .Times(testing::AtMost(2)) 263 .Times(testing::AtMost(2))
262 .WillOnce(DelayCloseBrowserMock(&loop_, 2000, &new_window_mock)); 264 .WillOnce(DelayCloseBrowserMock(&loop_, 2000, &new_window_mock));
263 265
264 EXPECT_CALL(new_window_mock, OnQuit()).WillOnce(CloseBrowserMock(&mock_)); 266 EXPECT_CALL(new_window_mock, OnQuit()).WillOnce(CloseBrowserMock(&mock_));
265 267
266 LaunchIEAndNavigate(link_page_url()); 268 LaunchIEAndNavigate(link_page_url());
267 } 269 }
268 270
269 } // namespace 271 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698