Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(91)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Issue
2810026
: Add VBDEBUG macro for debug output. (Closed)
Created:
10 years, 6 months ago by
Randall Spangler
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/vboot_reference.git
Visibility:
Public.
Description
Add VBDEBUG macro for debug output. Replaced in firmware/ lib; not replaced in host-side utils/tests.
Patch Set 1
#
Created:
10 years, 6 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+102 lines, -95 lines
)
Patch
M
Makefile
View
1 chunk
+2 lines, -1 line
0 comments
Download
M
firmware/include/utility.h
View
1 chunk
+7 lines, -0 lines
0 comments
Download
M
firmware/lib/cgptlib/cgptlib.c
View
4 chunks
+10 lines, -10 lines
0 comments
Download
M
firmware/lib/cryptolib/rsa.c
View
3 chunks
+5 lines, -7 lines
0 comments
Download
M
firmware/lib/rollback_index.c
View
1 chunk
+1 line, -1 line
0 comments
Download
M
firmware/lib/vboot_common.c
View
9 chunks
+28 lines, -28 lines
0 comments
Download
M
firmware/lib/vboot_firmware.c
View
9 chunks
+20 lines, -19 lines
0 comments
Download
M
firmware/lib/vboot_kernel.c
View
24 chunks
+29 lines, -29 lines
0 comments
Download
Messages
Total messages: 2 (0 generated)
Expand Messages
|
Collapse Messages
Randall Spangler
10 years, 6 months ago (2010-06-24 03:55:04 UTC)
#1
Bill Richardson
LGTM
10 years, 6 months ago (2010-06-24 04:05:28 UTC)
#2
LGTM
Expand Messages
|
Collapse Messages
Issue 2810026: Add VBDEBUG macro for debug output. (Closed)
Created 10 years, 6 months ago by Randall Spangler
Modified 9 years, 7 months ago
Reviewers: Bill Richardson
Base URL: ssh://gitrw.chromium.org/vboot_reference.git
Comments: 0
This is Rietveld
408576698