Issue 2809072: Don't sort dependencies by name anymore since it can be an issue for some kind of DEPS setup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2809072: Don't sort dependencies by name anymore since it can be an issue for some kind of DEPS setup. (Closed)

Created:
10 years, 5 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, bmcquade1

Visibility:
Public.

Don't sort dependencies by name anymore since it can be an issue for some kind of DEPS setup. PageSpeed is an example of such ordering dependency. TBR=bradnelson Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53377

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	gclient.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	tests/gclient_smoketest.py	View		1 chunk	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

M-A Ruel

This doesn't completely fix the issue but this is one of the necessary fixes.

10 years, 5 months ago (2010-07-22 20:45:55 UTC) #1

LGTM