gclient.py - Issue 2809072: Don't sort dependencies by name anymore since it can be an issue for some kind of DEPS setup.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 2809072: Don't sort dependencies by name anymore since it can be an issue for some kind of DEPS setup. (Closed)

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index 42a6938dd0c287836f24459eda8b508a9cf95e93..9a722f7253e3cee2844d2574631ad60ec65f7720 100644

--- a/gclient.py

+++ b/gclient.py

@@ -289,8 +289,6 @@ class Dependency(GClientKeywords):

if name in [s.name for s in self.dependencies]:

raise

self.dependencies.append(Dependency(self, name, url))

- # Sort by name.

- self.dependencies.sort(key=lambda x: x.name)

logging.info('Loaded: %s' % str(self))

def RunCommandRecursively(self, options, revision_overrides,

« no previous file with comments | « no previous file | tests/gclient_smoketest.py » ('j') | no next file with comments »