Rewrote handing of auto-reconnection and network changes for sync notifier.

Rewrote handing of auto-reconnection and network changes for sync notifier.

BUG=47883
TEST=manual (turning network connection off and on)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53839

[akalin, 2010-07-15 21:04:36]

+tim for review.  This may have to wait until mstone-7.

[akalin, 2010-07-16 20:40:14]

Ping!

On 2010/07/15 21:04:36, akalin wrote:
> +tim for review.  This may have to wait until mstone-7.

[akalin, 2010-07-20 17:56:19]

ping!

On 2010/07/16 20:40:14, akalin wrote:
> Ping!
> 
> On 2010/07/15 21:04:36, akalin wrote:
> > +tim for review.  This may have to wait until mstone-7.

[tim (not reviewing), 2010-07-22 21:00:01]

http://codereview.chromium.org/2809056/diff/1/7
File jingle/notifier/communicator/login.cc (right):

http://codereview.chromium.org/2809056/diff/1/7#newcode108
jingle/notifier/communicator/login.cc:108: TryReconnect();
doesn't it only really make sense to try to reconnect if this is an xmpp error?
What does retrying get you if it was a cert expiration or proxy auth error?

[akalin, 2010-07-22 21:15:40]

http://codereview.chromium.org/2809056/diff/1/7
File jingle/notifier/communicator/login.cc (right):

http://codereview.chromium.org/2809056/diff/1/7#newcode108
jingle/notifier/communicator/login.cc:108: TryReconnect();
On 2010/07/22 21:00:01, timsteele wrote:
> doesn't it only really make sense to try to reconnect if this is an xmpp
error?
> What does retrying get you if it was a cert expiration or proxy auth error?

The problem is, once we stop trying to reconnect, notifications won't work until
a browser restart / network state change.  I'd rather always try to reconnect,
relying on the exponential backoff to avoid hammering the buzz servers.

Cert expirations / proxy auth errors could both conceivably be fixed by the next
auto-reconnect, e.g. the system clock may be reset correctly, the proxy settings
are changed to one that doesn't require auth.

[tim (not reviewing), 2010-07-22 21:41:27]

LGTM

(Just in case, have you tested offline startup, and then turning on the network
connection?)

[akalin (wrong akalin), 2010-07-23 00:10:20]

I'll do that (and some more testing) before I check in.

On Thu, Jul 22, 2010 at 2:41 PM,  <tim@chromium.org> wrote:
> LGTM
>
> (Just in case, have you tested offline startup, and then turning on the
> network
> connection?)
>
> http://codereview.chromium.org/2809056/show
>



-- 
Frederick Akalin
Software Engineer