Issue 2808075: Update the TLS False Start patch. Replace TABs by spaces...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2808075: Update the TLS False Start patch. Replace TABs by spaces... (Closed)

Created:
10 years, 4 months ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Update the TLS False Start patch. Replace TABs by spaces in ssl.h. Add comments to ssl3con.c to make it clear that we call the handshakeCallback only once. Fix incorrect -h option in new test cases in sslstress.txt. R=agl BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54146

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -35 lines)			Patch
M	net/third_party/nss/patches/falsestart.patch	View	12 chunks	+32 lines, -30 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/third_party/nss/ssl/ssl3con.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM. (By the way. I deliberately setup vim to insert tabs into NSS code because ...

10 years, 4 months ago (2010-07-29 14:32:22 UTC) #2

wtc

10 years, 4 months ago (2010-07-29 18:31:16 UTC) #3

It's a good idea to use tabs in NSS code when the file you modify
uses tabs consistently.  This is true of many files in the
lib/pk11wrap and lib/softoken directories, and generally true for
files in lib/ssl.

I removed those tabs from ssl.h simply because they make the
code seem misaligned in a patch/diff file, which inserts + or - at
the beginning of the line.  It is a gratuitous change -- I just
wanted the patch to make a good first impression on NSS code
reviewers.

Expand Messages | Collapse Messages