Allow randomized search engines in selection dialog....

Allow randomized search engines in selection dialog.

Add an option in the master_preferences to randomize the order of logos in the search engine selection screen.  This allows us to cull out a small subset of users to take part in a test of the effects of logo position on search engine choice.

I also filed http://crbug.com/46606 to remind me to revert this change when testing is complete.

BUG=46302
TEST=Add the following options to master_preferences:

 "distribution": {
    "search_engine_experiment": true,
    "search_engine_experiment_randomize": true
  }

Run a few times as --first-run, and see search engines appear in random order in the selection box.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49950

[mattm, 2010-06-16 00:20:26]

lgtm with comments

http://codereview.chromium.org/2808006/diff/1/7
File chrome/browser/views/first_run_customize_view.cc (right):

http://codereview.chromium.org/2808006/diff/1/7#newcode25
chrome/browser/views/first_run_customize_view.cc:25:
FirstRunCustomizeView::FirstRunCustomizeView(Profile* profile,
I believe the first arg should also go on the next line with this style of
wrapping

http://codereview.chromium.org/2808006/diff/1/9
File chrome/browser/views/first_run_search_engine_view.cc (right):

http://codereview.chromium.org/2808006/diff/1/9#newcode262
chrome/browser/views/first_run_search_engine_view.cc:262:
search_engine_choices_.end());
I guess it's not really important for this usage, but might be nicer to add a
RandomNumberGenerator adapter class to base/rand_util.h and let random_shuffle
use that instead of the C rand.

[Miranda Callahan, 2010-06-16 15:30:00]

http://codereview.chromium.org/2808006/diff/1/7
File chrome/browser/views/first_run_customize_view.cc (right):

http://codereview.chromium.org/2808006/diff/1/7#newcode25
chrome/browser/views/first_run_customize_view.cc:25:
FirstRunCustomizeView::FirstRunCustomizeView(Profile* profile,
On 2010/06/16 00:20:26, mattm wrote:
> I believe the first arg should also go on the next line with this style of
> wrapping

Done.

http://codereview.chromium.org/2808006/diff/1/9
File chrome/browser/views/first_run_search_engine_view.cc (right):

http://codereview.chromium.org/2808006/diff/1/9#newcode262
chrome/browser/views/first_run_search_engine_view.cc:262:
search_engine_choices_.end());
On 2010/06/16 00:20:26, mattm wrote:
> I guess it's not really important for this usage, but might be nicer to add a
> RandomNumberGenerator adapter class to base/rand_util.h and let random_shuffle
> use that instead of the C rand.

Good idea -- I'll file a bug for it, but will let it go for this usage.