Allow randomized search engines in selection dialog....

chrome/browser/views/first_run_search_engine_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/first_run_search_engine_view.h"
 
+#include <algorithm>
 #include <map>
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/i18n/rtl.h"
+#include "base/time.h"
 #include "chrome/browser/options_window.h"
 #include "chrome/browser/profile.h"
 #include "chrome/browser/search_engines/template_url.h"
 #include "chrome/browser/search_engines/template_url_model.h"
 #include "chrome/browser/search_engines/template_url_prepopulate_data.h"
 #include "gfx/font.h"
 #include "grit/browser_resources.h"
 #include "grit/chromium_strings.h"
 #include "grit/google_chrome_strings.h"
 #include "grit/generated_resources.h"
 #include "grit/locale_settings.h"
 #include "grit/theme_resources.h"
 #include "views/controls/button/button.h"
 #include "views/controls/image_view.h"
 #include "views/controls/label.h"
 #include "views/controls/separator.h"
 #include "views/standard_layout.h"
 #include "views/view_text_utils.h"
 #include "views/window/window.h"
 
+using base::Time;
 using TemplateURLPrepopulateData::SearchEngineType;
 
 namespace {
 
 // These strings mark the embedded link in IDS_FIRSTRUN_SEARCH_SUBTEXT.
 const wchar_t* kBeginLink = L"BEGIN_LINK_SE";
 const wchar_t* kEndLink = L"END_LINK_SE";
 
 // Represents an id for which we have no logo.
 const int kNoLogo = -1;
@@ skipping 107 matching lines @@
     return choice_view_->GetPreferredSize().height();
   }
 }
 
 void SearchEngineChoice::SetChoiceViewBounds(int x, int y, int width,
                                              int height) {
   choice_view_->SetBounds(x, y, width, height);
 }
 
 FirstRunSearchEngineView::FirstRunSearchEngineView(
-    SearchEngineSelectionObserver* observer, Profile* profile)
+    SearchEngineSelectionObserver* observer, Profile* profile, bool randomize)
     : profile_(profile),
       observer_(observer),
-      text_direction_is_rtl_(base::i18n::IsRTL()) {
+      text_direction_is_rtl_(base::i18n::IsRTL()),
+      randomize_(randomize) {
   DCHECK(observer);
   // Don't show ourselves until all the search engines have loaded from
   // the profile -- otherwise we have nothing to show.
   SetVisible(false);
 
   // Start loading the search engines for the given profile.
   search_engines_model_ = profile_->GetTemplateURLModel();
   if (search_engines_model_) {
     DCHECK(!search_engines_model_->loaded());
     search_engines_model_->AddObserver(this);
@@ skipping 70 matching lines @@
     AddChildView(choice->GetView());  // The logo or text view.
     AddChildView(choice);  // The button associated with the choice.
   }
   // Push the default choice to the fourth position.
   if (default_choice) {
     search_engine_choices_.push_back(default_choice);
     AddChildView(default_choice->GetView());  // The logo or text view.
     AddChildView(default_choice);  // The button associated with the choice.
   }
 
+  // Randomize order of logos if option has been set.
+  if (randomize_) {
+    int seed = static_cast<int>(Time::Now().ToInternalValue());
+    srand(seed);
+    std::random_shuffle(search_engine_choices_.begin(),
+                        search_engine_choices_.end());

[mattm, 2010/06/16 00:20:26]

I guess it's not really important for this usage, but might be nicer to add a
RandomNumberGenerator adapter class to base/rand_util.h and let random_shuffle
use that instead of the C rand.

[Miranda Callahan, 2010/06/16 15:30:00]

Good idea -- I'll file a bug for it, but will let it go for this usage.

+  }
+
   // Now that we know how many logos to show, lay out and become visible.
   SetVisible(true);
   Layout();
   SchedulePaint();
 }
 
 gfx::Size FirstRunSearchEngineView::GetPreferredSize() {
   return views::Window::GetLocalizedContentsSize(
       IDS_FIRSTRUN_SEARCH_ENGINE_SELECTION_WIDTH_CHARS,
       IDS_FIRSTRUN_SEARCH_ENGINE_SELECTION_HEIGHT_LINES);
@@ skipping 210 matching lines @@
       text_direction_is_rtl_, label_bounds, font);
 
   options_link_->SetBounds(link_rect.x(), link_rect.y(), link_rect.width(),
                            link_rect.height());
 }
 
 std::wstring FirstRunSearchEngineView::GetWindowTitle() const {
   return l10n_util::GetString(IDS_FIRSTRUN_DLG_TITLE);
 }