Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_service.cc (revision 10269)
+++ chrome/browser/safe_browsing/safe_browsing_service.cc (working copy)
@@ -184,7 +184,7 @@
if (!resetting_) {
Time start_time = Time::Now();
bool need_check = database_->NeedToCheckUrl(url);
- UMA_HISTOGRAM_TIMES(L"SB.BloomFilter", Time::Now() - start_time);
+ UMA_HISTOGRAM_TIMES("SB.BloomFilter", Time::Now() - start_time);
if (!need_check)
return true; // The url is definitely safe.
}
@@ -223,7 +223,7 @@
&full_hits,
protocol_manager_->last_update());
- UMA_HISTOGRAM_TIMES(L"SB2.FilterCheck", base::Time::Now() - check_start);
+ UMA_HISTOGRAM_TIMES("SB2.FilterCheck", base::Time::Now() - check_start);
if (!prefix_match)
return true; // URL is okay.
@@ -383,7 +383,7 @@
if (!enabled_ || checks_.find(check) == checks_.end())
return;
- UMA_HISTOGRAM_TIMES(L"SB.Database", Time::Now() - check->start);
+ UMA_HISTOGRAM_TIMES("SB.Database", Time::Now() - check->start);
if (check->client && check->need_get_hash) {
// We have a partial match so we need to query Google for the full hash.
// Clean up will happen in HandleGetHashResults.
@@ -464,9 +464,9 @@
DCHECK(enabled_);
if (new_safe_browsing_)
- UMA_HISTOGRAM_LONG_TIMES(L"SB2.Network", Time::Now() - check->start);
+ UMA_HISTOGRAM_LONG_TIMES("SB2.Network", Time::Now() - check->start);
else
- UMA_HISTOGRAM_LONG_TIMES(L"SB.Network", Time::Now() - check->start);
+ UMA_HISTOGRAM_LONG_TIMES("SB.Network", Time::Now() - check->start);
std::vector<SBPrefix> prefixes = check->prefix_hits;
OnHandleGetHashResults(check, full_hashes); // 'check' is deleted here.
@@ -711,9 +711,9 @@
void SafeBrowsingService::LogPauseDelay(TimeDelta time) {
if (new_safe_browsing_)
- UMA_HISTOGRAM_LONG_TIMES(L"SB2.Delay", time);
+ UMA_HISTOGRAM_LONG_TIMES("SB2.Delay", time);
else
- UMA_HISTOGRAM_LONG_TIMES(L"SB.Delay", time);
+ UMA_HISTOGRAM_LONG_TIMES("SB.Delay", time);
}
void SafeBrowsingService::CacheHashResults(
@@ -748,10 +748,10 @@
void SafeBrowsingService::RunQueuedClients() {
DCHECK(MessageLoop::current() == io_loop_);
- HISTOGRAM_COUNTS(L"SB.QueueDepth", queued_checks_.size());
+ HISTOGRAM_COUNTS("SB.QueueDepth", queued_checks_.size());
while (!queued_checks_.empty()) {
QueuedCheck check = queued_checks_.front();
- HISTOGRAM_TIMES(L"SB.QueueDelay", Time::Now() - check.start);
+ HISTOGRAM_TIMES("SB.QueueDelay", Time::Now() - check.start);
CheckUrl(check.url, check.client);
queued_checks_.pop_front();
}
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_database_bloom.cc ('k') | chrome/browser/sessions/session_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698