Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6488)

Unified Diff: chrome/browser/metrics/metrics_service.cc

Issue 28046: Use string for Histogram names since these are all ASCII anyway wide-characte... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/memory_details.cc ('k') | chrome/browser/net/dns_host_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/metrics_service.cc
===================================================================
--- chrome/browser/metrics/metrics_service.cc (revision 10269)
+++ chrome/browser/metrics/metrics_service.cc (working copy)
@@ -736,7 +736,7 @@
// TODO(jar): Integrate bounds on log recording more consistently, so that we
// can stop recording logs that are too big much sooner.
if (current_log_->num_events() > log_event_limit_) {
- UMA_HISTOGRAM_COUNTS(L"UMA.Discarded Log Events",
+ UMA_HISTOGRAM_COUNTS("UMA.Discarded Log Events",
current_log_->num_events());
current_log_->CloseLog();
delete current_log_;
@@ -833,7 +833,7 @@
if (pending_log_text_.length() >
static_cast<size_t>(kUploadLogAvoidRetransmitSize)) {
- UMA_HISTOGRAM_COUNTS(L"UMA.Large Accumulated Log Not Persisted",
+ UMA_HISTOGRAM_COUNTS("UMA.Large Accumulated Log Not Persisted",
static_cast<int>(pending_log_text_.length()));
return;
}
@@ -1226,12 +1226,12 @@
if (response_code != 200 &&
pending_log_text_.length() >
static_cast<size_t>(kUploadLogAvoidRetransmitSize)) {
- UMA_HISTOGRAM_COUNTS(L"UMA.Large Rejected Log was Discarded",
+ UMA_HISTOGRAM_COUNTS("UMA.Large Rejected Log was Discarded",
static_cast<int>(pending_log_text_.length()));
discard_log = true;
} else if (response_code == 400) {
// Bad syntax. Retransmission won't work.
- UMA_HISTOGRAM_COUNTS(L"UMA.Unacceptable_Log_Discarded", state_);
+ UMA_HISTOGRAM_COUNTS("UMA.Unacceptable_Log_Discarded", state_);
discard_log = true;
}
@@ -1542,7 +1542,7 @@
// TODO(jar): There is a bug causing this to be called too many times, and
// the log overflows. For now, we won't record these events.
- UMA_HISTOGRAM_COUNTS(L"UMA.LogLoadComplete called", 1);
+ UMA_HISTOGRAM_COUNTS("UMA.LogLoadComplete called", 1);
return;
const Details<LoadNotificationDetails> load_details(details);
« no previous file with comments | « chrome/browser/memory_details.cc ('k') | chrome/browser/net/dns_host_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698