Issue 2800004: Fix broken build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2800004: Fix broken build. (Closed)

Created:
10 years, 6 months ago by dmac

Modified:
9 years, 7 months ago

Reviewers:
Sergey Ulanov, Alpha Left Google

CC:
chromium-reviews, dmac, awong, garykac

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix broken build. TEST=build release BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49846

Patch Set 1 #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	remoting/client/plugin/compression.cc	View		2 chunks	+12 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

10 years, 6 months ago (2010-06-15 22:50:03 UTC) #3

http://codereview.chromium.org/2800004/diff/1/2
File remoting/client/plugin/compression.cc (right):

http://codereview.chromium.org/2800004/diff/1/2#newcode36
remoting/client/plugin/compression.cc:36: assert(ret != Z_STREAM_ERROR);
This should be replaced with DCHECK. I think, it wouldn't break if this was a
DCHECK.

Expand Messages | Collapse Messages