Fix broken build.

remoting/client/plugin/compression.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/plugin/compression.h"
 
 #include <assert.h>
 
 namespace remoting {
 
@@ skipping 11 matching lines @@
   stream_.avail_in = size;
   stream_.next_in = reinterpret_cast<Bytef*>(buffer);
 
   // Expand the internal buffer.
   while (true) {
     int last_size = buffer_.size();
     buffer_.resize(last_size + kZLIB_CHUNK);
     stream_.avail_out = kZLIB_CHUNK;
     stream_.next_out = reinterpret_cast<Bytef*>(&buffer_[last_size]);
     int ret = deflate(&stream_, flush);
-    assert(ret != Z_STREAM_ERROR);
+
+    // Check ret before the assert so that we don't get an unused variable
+    // warning in release builds.
+    if (ret == Z_STREAM_ERROR) {
+      assert(ret != Z_STREAM_ERROR);

[Sergey Ulanov, 2010/06/15 22:50:03]

This should be replaced with DCHECK. I think, it wouldn't break if this was a
DCHECK.

+    }
 
     // Shrink the size of the vector. It doesn't alter the capacity.
     int compressed = kZLIB_CHUNK - stream_.avail_out;
     buffer_.resize(last_size + compressed);
     if (!compressed)
       break;
   }
 }
 
 void ZCompressor::Write(char* buffer, int size) {
@@ skipping 31 matching lines @@
 void ZDecompressor::WriteInternal(char* buffer, int size, int flush) {
   stream_.avail_in = size;
   stream_.next_in = reinterpret_cast<Bytef*>(buffer);
 
   while (true) {
     int last_size = buffer_.size();
     buffer_.resize(last_size + kZLIB_CHUNK);
     stream_.avail_out = kZLIB_CHUNK;
     stream_.next_out = reinterpret_cast<Bytef*>(&buffer_[last_size]);
     int ret = inflate(&stream_, flush);
-    assert(ret != Z_STREAM_ERROR);
+
+    // Check ret before the assert so that we don't get an unused variable
+    // warning in release builds.
+    if (ret == Z_STREAM_ERROR) {
+      assert(ret != Z_STREAM_ERROR);
+    }
 
     // Shrink the size of the vector. It doesn't alter the capacity.
     int decompressed = kZLIB_CHUNK - stream_.avail_out;
     buffer_.resize(last_size + decompressed);
     if (!decompressed)
       break;
   }
 }
 
 void ZDecompressor::Write(char* buffer, int size) {
@@ skipping 11 matching lines @@
 int ZDecompressor::GetRawSize() {
   return buffer_.size();
 }
 
 int ZDecompressor::GetCompressedSize() {
   // I don't care.
   return 0;
 }
 
 }  // namespace remoting