Issue 2799040: Skip sanity checks for TSan/Mac...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2799040: Skip sanity checks for TSan/Mac... (Closed)

Created:
10 years, 5 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Skip sanity checks for TSan/Mac BUG=47844 TEST=TSan/Mac should become green TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51123

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/valgrind/valgrind_test.py	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

_com_google_glider

10 years, 5 months ago (2010-06-29 15:39:32 UTC) #2

LGTM

On Tue, Jun 29, 2010 at 6:10 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Skip sanity checks for TSan/Mac
> BUG=47844
> TEST=TSan/Mac should become green
> TBR=glider
>
> Please review this at http://codereview.chromium.org/2799040/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/valgrind_test.py
>
>
> Index: tools/valgrind/valgrind_test.py
> ===================================================================
> --- tools/valgrind/valgrind_test.py     (revision 50834)
> +++ tools/valgrind/valgrind_test.py     (working copy)
> @@ -781,6 +781,11 @@
>
>   tool = ToolFactory().Create(tool_name)
>   MODULES_TO_SANITY_CHECK = ["base"]
> +
> +  # TODO(timurrrr): this is a temporary workaround for
> http://crbug.com/47844
> +  if tool_name == "tsan" and common.IsMac():
> +    MODULES_TO_SANITY_CHECK = []
> +
>   check_sanity = module in MODULES_TO_SANITY_CHECK
>   return tool.Main(args, check_sanity)
>
>
>
>



-- 
Alexander Potapenko
Software Engineer
Google Moscow

Expand Messages | Collapse Messages