Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: tools/valgrind/valgrind_test.py

Issue 2799040: Skip sanity checks for TSan/Mac... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/python 1 #!/usr/bin/python
2 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 # valgrind_test.py 6 # valgrind_test.py
7 7
8 """Runs an exe through Valgrind and puts the intermediate files in a 8 """Runs an exe through Valgrind and puts the intermediate files in a
9 directory. 9 directory.
10 """ 10 """
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 tool_name = "memcheck" 774 tool_name = "memcheck"
775 args = argv[1:] 775 args = argv[1:]
776 for arg in args: 776 for arg in args:
777 if arg.startswith("--tool="): 777 if arg.startswith("--tool="):
778 tool_name = arg[7:] 778 tool_name = arg[7:]
779 args.remove(arg) 779 args.remove(arg)
780 break 780 break
781 781
782 tool = ToolFactory().Create(tool_name) 782 tool = ToolFactory().Create(tool_name)
783 MODULES_TO_SANITY_CHECK = ["base"] 783 MODULES_TO_SANITY_CHECK = ["base"]
784
785 # TODO(timurrrr): this is a temporary workaround for http://crbug.com/47844
786 if tool_name == "tsan" and common.IsMac():
787 MODULES_TO_SANITY_CHECK = []
788
784 check_sanity = module in MODULES_TO_SANITY_CHECK 789 check_sanity = module in MODULES_TO_SANITY_CHECK
785 return tool.Main(args, check_sanity) 790 return tool.Main(args, check_sanity)
786 791
787 if __name__ == "__main__": 792 if __name__ == "__main__":
788 if sys.argv.count("-v") > 0 or sys.argv.count("--verbose") > 0: 793 if sys.argv.count("-v") > 0 or sys.argv.count("--verbose") > 0:
789 logging_utils.config_root(logging.DEBUG) 794 logging_utils.config_root(logging.DEBUG)
790 else: 795 else:
791 logging_utils.config_root() 796 logging_utils.config_root()
792 # TODO(timurrrr): valgrind tools may use -v/--verbose as well 797 # TODO(timurrrr): valgrind tools may use -v/--verbose as well
793 798
794 ret = RunTool(sys.argv) 799 ret = RunTool(sys.argv)
795 sys.exit(ret) 800 sys.exit(ret)
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698