Issue 2798001: [Mac] Fix a leak in CookiesWindowControllerTest by giving BrowserTestHelper a fake IO thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2798001: [Mac] Fix a leak in CookiesWindowControllerTest by giving BrowserTestHelper a fake IO thread. (Closed)

Created:
10 years, 6 months ago by Robert Sesek

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Randy Smith (Not in Mondays)

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Fix a leak in CookiesWindowControllerTest by giving BrowserTestHelper a fake IO thread. Thanks to Randy Smith for tracking this down. BUG=31586 TEST=Valgrind Mac unit_tests stay green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49968

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -23 lines)			Patch
M	chrome/browser/cocoa/browser_test_helper.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/cookies_window_controller_unittest.mm	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Randy Smith (Not in Mondays)

LGTM, but since it's pretty much the change I suggested I'm not sure my opinion ...

10 years, 6 months ago (2010-06-14 15:09:21 UTC) #2

John Grabowski

10 years, 6 months ago (2010-06-15 19:47:44 UTC) #4

Excellent. LGTM.

Would help if you could add more comments in browser_test_helper.h explaining
why you added it, and the symptom of failure, to help someone tracking down
other similar problems.

Expand Messages | Collapse Messages