Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/cocoa/cookies_window_controller_unittest.mm

Issue 2798001: [Mac] Fix a leak in CookiesWindowControllerTest by giving BrowserTestHelper a fake IO thread. (Closed) Base URL: http://src.chromium.org/git/chromium.git
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/browser_test_helper.h ('k') | tools/valgrind/memcheck/suppressions_mac.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/cookies_window_controller_unittest.mm
diff --git a/chrome/browser/cocoa/cookies_window_controller_unittest.mm b/chrome/browser/cocoa/cookies_window_controller_unittest.mm
index ea07ff102339c0f77d939b3667515dd5ae75c948..b02031f75e782fe9d0d566706630cd1e706c8bd6 100644
--- a/chrome/browser/cocoa/cookies_window_controller_unittest.mm
+++ b/chrome/browser/cocoa/cookies_window_controller_unittest.mm
@@ -51,8 +51,6 @@ namespace {
class CookiesWindowControllerTest : public CocoaTest {
public:
- CookiesWindowControllerTest()
- : io_thread_(ChromeThread::IO, MessageLoop::current()) {}
virtual void SetUp() {
CocoaTest::SetUp();
@@ -84,8 +82,6 @@ class CookiesWindowControllerTest : public CocoaTest {
protected:
BrowserTestHelper browser_helper_;
- // Need an IO thread to not leak from TestingProfile::CreateRequestContext().
- ChromeThread io_thread_;
scoped_nsobject<CookiesWindowController> controller_;
MockBrowsingDataDatabaseHelper* database_helper_;
MockBrowsingDataLocalStorageHelper* local_storage_helper_;
« no previous file with comments | « chrome/browser/cocoa/browser_test_helper.h ('k') | tools/valgrind/memcheck/suppressions_mac.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698